Skip to content

Conversation

@airy10
Copy link
Contributor

@airy10 airy10 commented Nov 28, 2025

This is implementing tools calling support for OpenAI (by implementing the "tools calling + sending back results" loop, and for the Apple Models (by implementing a FoundationsModel Tool to bridge the the AnyLanguageModel one). This also has a fix in the DynamicGenerationSchema -> GenerationSchema conversion where properties descriptions were lost

This is fixing #40 and #43

@airy10
Copy link
Contributor Author

airy10 commented Dec 3, 2025

(branch updated)

@mattt
Copy link
Owner

mattt commented Dec 3, 2025

@airy10 Thanks for your work on this. Taking a look now.

@airy10
Copy link
Contributor Author

airy10 commented Dec 3, 2025

I've not been able to test it with official Open AI server as I don't have any credit there. But it seems fine with OpenCode/Zen and Google servers. And my free credits on HuggingFace are gone too... I've checked the response content of the withTools test + tested using some modified version of your HuggingFace app and my GEDCOM MCP server and my MCP->FoundationModels bridge.

Copy link
Owner

@mattt mattt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good! I think we can simplify a lot of the conversion logic by leaning more on JSONSchema. Lemme know if you'd like me to take a stab at that.

@airy10
Copy link
Contributor Author

airy10 commented Dec 4, 2025

I've pushed my changes to use JSONSchema to build the FoundationModels dynamic schema

@mattt
Copy link
Owner

mattt commented Dec 11, 2025

@airy10 Thanks again for your work on this! I just fixed an issue with OpenAI tool calling, did some refactoring and added test coverage for dynamic schema generation. This is looking solid.

@mattt mattt merged commit ad2cb1a into mattt:main Dec 11, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants