Skip to content

Conversation

@serverwentdown
Copy link

This PR adds fallback to password when clicking the "Use password..." button.

Copy link

@henrik242 henrik242 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@patgmac
Copy link

patgmac commented Mar 28, 2017

Is this going to be merged?

@19h
Copy link

19h commented Jun 3, 2017

Please merge

@serverwentdown
Copy link
Author

@mattrajca?

@henrik242
Copy link

@serverwentdown Maybe about time to fork and release to homebrew? It doesn't seem like @mattrajca is active anymore.

@serverwentdown
Copy link
Author

Yep, seems like @mattrajca isn't active anymore.

@knu
Copy link

knu commented Jun 28, 2017

Looks great, and I've pushed this further and made it fall back when Touch ID is not available: serverwentdown#1

Software like Near Lock offers local authentication via iPhone/Apple Watch, so the bridge between sudo and the LocalAuthentication framework is useful even on MacBooks without Touch ID!

Fall back to password entry if Touch ID is not available
@serverwentdown
Copy link
Author

@knu Nice, I suppose you have tested it on non-TouchID MacBooks? I don't have mine at hand.

@knu
Copy link

knu commented Jun 28, 2017

@serverwentdown Yes, I've tested it on my 12" MacBook (2017) and it works perfectly. On the other hand I haven't tested it on a MBP with Touch ID because mine just got broken. 😞
Can you confirm that I didn't break anything with regard to Touch ID authentication?

@serverwentdown
Copy link
Author

@knu Yep, works fine on mine.

@serverwentdown
Copy link
Author

@henrik242 I'm not really interested in maintaining a homebrew tap... 😢

@henrik242
Copy link

henrik242 commented Jun 28, 2017

Maybe @jhochwald is interested instead?

@samm-git
Copy link

I can maintain homebrew tap. But do we have some repository with all PR included?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants