-
Notifications
You must be signed in to change notification settings - Fork 45
Added fallback to password entry #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
henrik242
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
|
Is this going to be merged? |
|
Please merge |
|
@serverwentdown Maybe about time to fork and release to homebrew? It doesn't seem like @mattrajca is active anymore. |
|
Yep, seems like @mattrajca isn't active anymore. |
|
Looks great, and I've pushed this further and made it fall back when Touch ID is not available: serverwentdown#1 Software like Near Lock offers local authentication via iPhone/Apple Watch, so the bridge between sudo and the LocalAuthentication framework is useful even on MacBooks without Touch ID! |
Fall back to password entry if Touch ID is not available
|
@knu Nice, I suppose you have tested it on non-TouchID MacBooks? I don't have mine at hand. |
|
@serverwentdown Yes, I've tested it on my 12" MacBook (2017) and it works perfectly. On the other hand I haven't tested it on a MBP with Touch ID because mine just got broken. 😞 |
|
@knu Yep, works fine on mine. |
|
@henrik242 I'm not really interested in maintaining a homebrew tap... 😢 |
|
Maybe @jhochwald is interested instead? |
|
I can maintain homebrew tap. But do we have some repository with all PR included? |
This PR adds fallback to password when clicking the "Use password..." button.