Skip to content

Conversation

@shogo82148
Copy link
Collaborator

fixes #172

@coveralls
Copy link

coveralls commented Sep 7, 2020

Coverage Status

Coverage remained the same at 12.075% when pulling b063ca2 on shogo82148:improve-merging-profiles into 769aead on mattn:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 12.075% when pulling a580f65 on shogo82148:improve-merging-profiles into 769aead on mattn:master.

@shogo82148
Copy link
Collaborator Author

Test fails because of https://golang.org/doc/go1.15#flag

When the flag package sees -h or -help, and those flags are not defined, it now prints a usage message. If the FlagSet was created with ExitOnError, FlagSet.Parse would then exit with a status of 2. In this release, the exit status for -h or -help has been changed to 0. In particular, this applies to the default handling of command line flags.

Copy link

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks! 🎉 👍

gocover.go Outdated
ret := make([]cover.ProfileBlock, 0, len(left)+len(right))
for len(left) > 0 && len(right) > 0 {
a, b := left[0], right[0]
if a.StartLine == b.StartLine && a.StartCol == b.StartCol && a.EndLine == b.EndLine && b.EndCol == b.EndCol {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Raw Output:
gocover.go:81:90: SA4000: identical expressions on the left and right side of the '==' operator (staticcheck)
		if a.StartLine == b.StartLine && a.StartCol == b.StartCol && a.EndLine == b.EndLine && b.EndCol == b.EndCol {

oops, I'll fix it. Thanks 🐶

@shogo82148 shogo82148 merged commit 7f581cf into mattn:master Sep 8, 2020
@shogo82148 shogo82148 deleted the improve-merging-profiles branch September 8, 2020 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing profiles when merging

3 participants