Use golang.org/x/sys/unix for android and *BSD #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation for android uses the same ioctl as linux and aix which is already implemented in isatty_tcgets.go Also, this no longer requires to use the frozen syscall package.
Use unix.IoctlGetTermios to implement IsTerminal on *BSD and no longer requires to use the frozen syscall package.
Clean up unused version hashes in go.sum by running `go mod tidy`.
Codecov Report
@@ Coverage Diff @@
## master #49 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 5 5
=====================================
Hits 5 5
Continue to review full report at Codecov.
|
Owner
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-use implementation in isatty_tcgets.go for android and implement isatty_bsd.go using IoctlGetTermios from golang.org/x/sys/unix. Also, clean up unused version hashes from go.mod.
See individual commits for details.