Add BenchmarkDotNet benchmark project and DataLoader benchmark#159
Merged
mattjohnsonpint merged 2 commits intomattjohnsonpint:mainfrom Feb 11, 2025
Merged
Add BenchmarkDotNet benchmark project and DataLoader benchmark#159mattjohnsonpint merged 2 commits intomattjohnsonpint:mainfrom
mattjohnsonpint merged 2 commits intomattjohnsonpint:mainfrom
Conversation
Contributor
Author
|
You could probably drop .NET SDKs below 8 I believe, newer ones build older targets. |
Owner
They'll build for older targets, but tests will fail if the older runtimes are not installed. See also actions/setup-dotnet#352 |
Owner
|
This is nice - thanks for the PR! Could you also please add a Github Action (or a workflow step to the existing two actions) that runs the benchmark and puts the output somewhere convenient (like the run summary output)? |
Contributor
Author
|
I'm not sure if it is beneficial as we are running on random CI runners, they would not be comparable. Maybe a separate PR? |
This was referenced Oct 20, 2025
Closed
This was referenced Oct 27, 2025
This was referenced Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.