Delete attachment redirect to the error page#181
Closed
Rajat-Dabade wants to merge 3 commits into
Closed
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
Author
|
Done as a part of this PR: #184 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deleting an attachment could succeed on the server while the UI still showed it, the confirm dialog stayed open, or the app crashed and sent users to the error page. This PR fixes client handling of attachment deletes and websocket tombstones.
The PR includes:
onDeleteand close the confirmation dialog after a successful delete.getUploadPercent/ upload-progress updates when the attachment row is already removed from Redux.updateAttachmentsreducer (no premature return that skipped batch items, safer parentId for tombstones).Ticket Link
https://mattermost.atlassian.net/browse/MM-68059