Fix: Board infinity redirect multiperson property#176
Fix: Board infinity redirect multiperson property#176Rajat-Dabade wants to merge 1 commit intomainfrom
Conversation
📝 WalkthroughWalkthroughSort logic in Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Comment |
@Rajat-Dabade As we discussed offline, it seems this PR fixes the issue that was causing the error. However, do we know why the redirects are happening when it finds an error? The customer reported that it kept looping an adding We can complete this PR and ship this fix to the customer but it's important that we find the cause of the redirects when there are errors because there may be other instances that there are errors and it should be able to manage them gracefully. |
|
Harshil is OOO so you probably need to swap him out for another reviewer |
Summary
Root Cause:
The crash happened in sortCards in
webapp/src/store/cards.tswhen:boardUserswas still empty becausefetchBoardMembershad not finished.usersByIdwas empty,aValueandbValuestayed as arrays (e.g. ["user_id_1", "user_id_2"]).(aValue as string).localeCompare(bValue as string).aValue.localeCompareis not a function./error?id=unknown.Steps to reproduce:
Before:
Screen.Recording.2026-03-11.at.2.20.21.PM.mov
After:
Screen.Recording.2026-03-11.at.2.14.27.PM.mov
Ticket Link
https://mattermost.atlassian.net/browse/MM-65641