Board blank page if no team id is present in localstorage#165
Merged
Conversation
Rajat-Dabade
requested review from
devinbinnie,
harshilsharma63 and
yasserfaraazkhan
Rajat-Dabade
added
2: Dev Review
devinbinnie
approved these changes
Feb 3, 2026
| return null | ||
| } | ||
|
|
||
| if (!teamID && !firstTeam && !lastTeamID && !teamsFetched) { |
Member
There was a problem hiding this comment.
Nit: We're checking 3 of these conditions twice in a row. Could simplify this.
harshilsharma63
approved these changes
Feb 5, 2026
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
yasserfaraazkhan
added
the
Setup Cloud Test Server
|
Plugin Spinwick PR #165 🎉 Test server created! Access here: https://boards-pr-165-tzz5w.test.mattermost.cloud
The test server was created successfully, but there was an issue installing or enabling the plugin automatically:
You can manually install the plugin:
Future commits will still attempt to automatically update the plugin. Installation ID: Credentials: Posted securely in this Mattermost channel - Look for PR #165 |
yasserfaraazkhan
approved these changes
Feb 9, 2026
|
Test server destroyed |
Rajat-Dabade
added a commit
that referenced
this pull request
Feb 16, 2026
* Checking if the last board id is present from the api * nit
Rajat-Dabade
added a commit
that referenced
this pull request
Apr 16, 2026
* Fixed broken tests * Remove the standalone test function * Fix most of the integration tests * Fix all authentication related tests * Fix integrations test for boards * Validation to modify comments (#152) * Upgraded board version to v9.2.2 (#156) * Updated mattermost/server/public/model version to v0.1.21 in boards (#158) * Fix: Viewer Role can Accessing Individual Cards if part of board (#162) * Fix: Filter not working correctly for text fields in Boards (#160) * workflows: adjust token permissions (#168) https://github.com/mattermost/mattermost-plugin-boards/security/code-scanning/7 https://github.com/mattermost/mattermost-plugin-boards/security/code-scanning/8 * Board blank page if no team id is present in localstorage (#165) * Checking if the last board id is present from the api * nit * Fixed critical bugs in Mattermost Boards plugin (#169) * Fixed critical bugs in Mattermost Boards plugin * Linter fixes * Linter * Minor * Use webapp exported markdown to card and board descriptions (#170) * Use webapp exported markdown to card and board descriptions * review comments: * Fix integrations test for boards * Fix the test for server/boards/configuration_test.go * TestGetMembersForBoard fixed * TestPermissionsLeaveBoardAsMember fixed * TestPermissionsListTeams fixed * TestPermissionsGetTeam fixed * Removed TestPermissionsRegenerateSignupToken as it is not required * TestPermissionsGetTeamUsers fixed * TestPermissionsTeamArchiveExport fixed * Fux TestPermissionsGetMe test * TestPermissionsGetMyMemberships fixed * TestPermissionsGetUser fixed * TestPermissionsUpdateUserConfig fixed * TestPermissionsCreateBoardsAndBlocks fixed * TestPermissionsJoinBoardAsMember fixed * TestPermissionsCreateCategory fixed * TestPermissionsGetFile fixed * TestPermissionsCreateSubscription fixed * TestPermissionsGetSubscriptions fixed * TestPermissionsOnboard fixed * TestPermissionsBoardArchiveExport * TestPermissionsBoardArchiveImport fixed * TestPermissionsChannels TestPermissionsChannel fixed * TestPermissionsGetStatistics fixed * TestSharing fixed * TestSidebar and TestHideUnhideBoard fixed * Fixed remaining tests * server test to ci * Linter fixes * Fix some test and added requireUserID function to check user id is present or not * coderabbit review comments fixed * Fix more tests * linter issue: * Fixed file related tests * remove the dead api call and added user check to attachSession middleware * linter fixes * Remove the mysql and sqlite check from test * fixed some tests * review comment and code rabbit suggestions * linter fixes * separated webapp-test and server-test in ci * ci persmission fix and nil pointer check * test fixes * ci fixes * ci fixes * fix tests * disabled webapp-test ci for now * review comments * sanitised file name that contain path traversal for write achieve files * linter fixes * panic issue fixed * linter fixes * test fixes * Fixed Webapp test for boards (#182) * Fixed Webapp test for boards * Added ci rule to run webapp test for boards --------- Co-authored-by: Nuno Simões <nasimoes@aiven.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Found an issue where if no team Id is present in the localstorage, the board on refresh on the page with URL
boards/teamgoes blank. This PR solves this issue. It fetches the team ID from the API call, looks for the first team and redirects it to that team.Ticket Link
https://mattermost.atlassian.net/browse/MM-67431