Do not import node:crypto in @matter/general #2796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This worked because typescript was previously too lenient on types. tsgo is stricter so we can't use node types without making them all available which is not desirable. So instead define the subset of the Node crypto interface we use. This is probably better anyway because it makes us more readily compatible with partial implementations from a type perspective.
Apollon77
approved these changes
Dec 8, 2025
Apollon77
added
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This worked because typescript was previously too lenient on types. tsgo is stricter so we can't use node types without making them all available which is not desirable. So instead define the subset of the Node crypto interface we use. This is probably better anyway because it makes us more readily compatible with partial implementations from a type perspective.