Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #151 +/- ##
==========================================
+ Coverage 90.37% 90.56% +0.19%
==========================================
Files 32 34 +2
Lines 1787 1908 +121
==========================================
+ Hits 1615 1728 +113
- Misses 172 180 +8 ☔ View full report in Codecov by Sentry. |
poljar
force-pushed
the
poljar/qr-login-pr
branch
2 times, most recently
from
2d270d5 to
0141214
Compare
21 tasks
dkasak
requested changes
May 8, 2024
Member
dkasak
left a comment
dkasak
left a comment
There was a problem hiding this comment.
Looks good, but I'm suggesting a handful of doc improvements.
dkasak
requested changes
May 9, 2024
Member
dkasak
left a comment
dkasak
left a comment
There was a problem hiding this comment.
Thanks for splitting up the constructors. I left a few more nits.
dkasak
approved these changes
May 15, 2024
This commits adds a Elliptic Curve Encryption Scheme, this scheme can be used in ephemeral situations where a full 3DH-based Olm session might be overkill or too hard to set up. The canonical example where this can be used is the QR code login feature in Matrix[1]. Co-authored-by: Denis Kasak <dkasak@termina.org.uk> Co-authored-by: Hugh Nimmo-Smith <hughns@users.noreply.github.com> [1]: matrix-org/matrix-spec-proposals#4108
poljar
force-pushed
the
poljar/qr-login-pr
branch
from
8a41847 to
013fe79
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commits adds a Elliptic Curve Encryption Scheme, this scheme can be used in ephemeral situations where a full 3DH-based Olm session might be overkill or too hard to set up.
The canonical example where this can be used is the QR code login feature in Matrix1.
Co-authored-by: Denis Kasak dkasak@termina.org.uk
Co-authored-by: Hugh Nimmo-Smith hughns@users.noreply.github.com
Footnotes
https://github.com/matrix-org/matrix-spec-proposals/pull/4108 ↩