Conversation
Contributor
Author
|
Well, I must be doing something wrong because this is now the correct branch name, the |
Member
|
@matrixbot retest this please |
Member
|
[this is supposed to be testing matrix-org/synapse#3184] |
Member
the reason it didn't pick up your synapse branch is that the synapse branch is on a fork of the repo rather than the matrix.org one. |
richvdh
approved these changes
Jul 27, 2018
Member
richvdh
left a comment
richvdh
left a comment
There was a problem hiding this comment.
lgtm, pending merge of matrix-org/synapse#3184
Member
|
@matrixbot retest this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed branch name to apparently make sytest happy which means this follows on from #456.