Update uses of matrix_put_e2e_keys to contain valid data#1411
Merged
anoadragon453 merged 1 commit intodevelopfrom Oct 7, 2025
Merged
Update uses of matrix_put_e2e_keys to contain valid data#1411anoadragon453 merged 1 commit intodevelopfrom
matrix_put_e2e_keys to contain valid data#1411anoadragon453 merged 1 commit intodevelopfrom
Conversation
After adding validation to `/keys/upload` on Synapse, uses of this function with mostly-empty bodies were no longer valid. This change adds fake test data to them where necessary.
reivilibre
approved these changes
Oct 7, 2025
anoadragon453
added a commit
that referenced
this pull request
Oct 7, 2025
anoadragon453
added a commit
that referenced
this pull request
Oct 7, 2025
Member
Author
|
This commit has been backported to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After adding validation to
/keys/uploadon Synapse, uses of this function with mostly-empty bodies were no longer valid.This change adds fake test data to them where necessary.
This is paired with element-hq/synapse#17097, which was accidentally merged before these tests were.
This change should be backported to the
release-v1.138andrelease-v1.139branches, as the linked PR was backported to those Synapse releases.