Skip to content

Handle servers which send /state requests#1223

Merged
richvdh merged 3 commits intodevelopfrom
rav/allow_state_requests
Mar 28, 2022
Merged

Handle servers which send /state requests#1223
richvdh merged 3 commits intodevelopfrom
rav/allow_state_requests

Conversation

@richvdh
Copy link
Copy Markdown
Member

@richvdh richvdh commented Mar 25, 2022

Some server implementations may make /state requests when there is a large
amount of state to sync up; add code to handle that.

Some server implementations may make `/state` requests when there is a large
amount of state to sync up; add code to handle that.
@richvdh richvdh marked this pull request as ready for review March 25, 2022 15:04
@richvdh richvdh requested a review from a team as a code owner March 25, 2022 15:04
@squahtx squahtx self-assigned this Mar 25, 2022
@squahtx squahtx removed their assignment Mar 25, 2022
@richvdh richvdh requested a review from squahtx March 28, 2022 17:29
Copy link
Copy Markdown
Contributor

@squahtx squahtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@richvdh richvdh merged commit e53d72b into develop Mar 28, 2022
@richvdh richvdh deleted the rav/allow_state_requests branch March 28, 2022 18:19
richvdh added a commit that referenced this pull request Mar 31, 2022
A follow-up to #1223: Another place that we can get `/state` requests.
richvdh added a commit that referenced this pull request Mar 31, 2022
* Accept `/state` reqeusts in `create_outlier_event`

A follow-up to #1223: Another place that we can get `/state` requests.

* Register `/state` listeners earlier

Per comments on #1231: we ought to set up the listeners for `/state`
earlier. We also create a helper function to make it easier.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants