This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Switch devenv dependency in the nix development environment to the latest release (instead of the development branch)#16063
Merged
anoadragon453 merged 2 commits intodevelopfrom Aug 23, 2023
Merged
Conversation
Contributor
|
Nominating Oliver to review as the other Nix user. |
reivilibre
approved these changes
Aug 23, 2023
Broke in #16019. This would have been caught if someone ran 'devenv up' during manual testing of that PR, or better yet, if we had CI for the nix developer environment. Switch back to the latest release version, which doesn't have the upstream issue: cachix/devenv#756
anoadragon453
force-pushed
the
anoa/devenv_v0.6.3
branch
from
0f8e333 to
3ce99e1
Compare
Member
Author
|
Failing CI is a known flake: matrix-org/sytest#1364 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cachix/devenv#756 introduced a regression into the development branch of devenv which caused the
devenv upcommand (which we utilise to start up a local Synapse, postgres and redis) to return an error.We updated our pinned dependencies in #16019. This would have been caught if someone ran 'devenv up' during manual testing of that PR, or better yet, if we had CI for the nix developer environment.
This PR switches back to the latest release version of devenv (v0.6.3), which doesn't have the regression. We are not relying on any features introduced since that version was tagged.
Uses the same changelog as #16019.