Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Fix background updates failing to add unique indexes on receipts #14453

Merged
squahtx merged 7 commits into from
Nov 16, 2022
Merged

Fix background updates failing to add unique indexes on receipts #14453

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b1d191d
Fix broken upserts to `receipts_linearized` and `receipts_graph`
Nov 11, 2022
580a416
Clean up duplicate receipts when creating unique indexes
Nov 11, 2022
dfe9946
Add newsfile
Nov 15, 2022
7bf42a9
Merge remote-tracking branch 'origin/develop' into squah/fix_receipts…
Nov 15, 2022
e654f8c
Fix background update on postgres and keep last linearized receipt
Nov 15, 2022
8cb1bcb
Merge remote-tracking branch 'origin/develop' into squah/fix_receipts…
Nov 16, 2022
6eb87c9
Merge remote-tracking branch 'origin/develop' into squah/fix_receipts…
Nov 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions synapse/storage/databases/main/receipts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -702,9 +702,6 @@ def _insert_linearized_receipt_txn(
"data": json_encoder.encode(data),
},
where_clause=where_clause,
# receipts_linearized has a unique constraint on
# (user_id, room_id, receipt_type), so no need to lock
lock=False,
Comment on lines -705 to -707
Copy link
Copy Markdown
Contributor

@DMRobertson DMRobertson Nov 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To double check: is the table correctly deemed safe to upsert into when the relevant background updates have run? (Wasn't sure how the second commit would affect this, if at all)

Copy link
Copy Markdown
Contributor Author

@squahtx squahtx Nov 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, once the unique index has been added by the background update, we will be able to rely on native upserts again (and the value of lock won't matter).

)

return rx_ts
Expand Down Expand Up @@ -862,9 +859,6 @@ def _insert_graph_receipt_txn(
"data": json_encoder.encode(data),
},
where_clause=where_clause,
# receipts_graph has a unique constraint on
# (user_id, room_id, receipt_type), so no need to lock
lock=False,
)


Expand Down