This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Add sample worker files for pusher and federation_sender#14077
Merged
squahtx merged 2 commits intomatrix-org:developfrom Oct 7, 2022
Merged
Add sample worker files for pusher and federation_sender#14077squahtx merged 2 commits intomatrix-org:developfrom
pusher and federation_sender#14077squahtx merged 2 commits intomatrix-org:developfrom
Conversation
dklimpel
commented
Oct 6, 2022
Comment on lines
+1
to
+8
| worker_app: synapse.app.federation_sender | ||
| worker_name: federation_sender1 | ||
|
|
||
| # The replication listener on the main synapse process. | ||
| worker_replication_host: 127.0.0.1 | ||
| worker_replication_http_port: 9093 | ||
|
|
||
| worker_log_config: /etc/matrix-synapse/federation-sender-log.yaml |
Contributor
Author
There was a problem hiding this comment.
In my environment, this configuration is running.
In #12737 was added a config with an undocumented replication listener.
Contributor
There was a problem hiding this comment.
I think the replication listener in #12737 is unnecessary. The list of federation senders is stored in WorkerConfig.federation_shard_config, and nothing seems to send out replication requests based off of it.
squahtx
approved these changes
Oct 7, 2022
Contributor
squahtx
left a comment
There was a problem hiding this comment.
lgtm! Thanks for updating the docs.
Comment on lines
+1
to
+8
| worker_app: synapse.app.federation_sender | ||
| worker_name: federation_sender1 | ||
|
|
||
| # The replication listener on the main synapse process. | ||
| worker_replication_host: 127.0.0.1 | ||
| worker_replication_http_port: 9093 | ||
|
|
||
| worker_log_config: /etc/matrix-synapse/federation-sender-log.yaml |
Contributor
There was a problem hiding this comment.
I think the replication listener in #12737 is unnecessary. The list of federation senders is stored in WorkerConfig.federation_shard_config, and nothing seems to send out replication requests based off of it.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to:
Pull Request Checklist
EventStoretoEventWorkerStore.".code blocks.(run the linters)
Signed-off-by: Dirk Klimpel dirk@klimpel.org