This repository was archived by the owner on Apr 26, 2024. It is now read-only.
WIP: Enable email notification on SSO when set in the config#11805
Closed
lukasdenk wants to merge 2 commits intomatrix-org:developfrom
lukasdenk:solve_10882
Closed
WIP: Enable email notification on SSO when set in the config#11805lukasdenk wants to merge 2 commits intomatrix-org:developfrom lukasdenk:solve_10882
lukasdenk wants to merge 2 commits intomatrix-org:developfrom
lukasdenk:solve_10882
Conversation
Member
Contributor
Author
|
Set to |
Member
|
@lukasdenk From your point of view -- are you waiting on some feedback from the Synapse team or do you need to investigate more what's going on? I'm wondering if the review request accurately represents the current status! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10882.
Fix a bug where email notifications were not enabled when the user logged in via an SSO even though in the config
email.notif_for_new_usersandemail.enable_notifswere set totrue.Tested with keycloak.
Signed-off by: Lukas Denk, lukasdenk@web.de
Pull Request Checklist
EventStoretoEventWorkerStore.".code blocks.(run the linters)