Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Fix a bug introduced in Synapse v1.50.0rc1 whereby outbound federation could fail because too many EDUs were produced for device updates. #11730

Merged
reivilibre merged 17 commits into from
Jan 13, 2022
Merged

Fix a bug introduced in Synapse v1.50.0rc1 whereby outbound federation could fail because too many EDUs were produced for device updates. #11730

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
e3665f4
Clarify docstring
reivilibre Jan 11, 2022
9f54d0f
Add a few HL-style invariant comments to help reason about how long c…
reivilibre Jan 11, 2022
ad8da37
Extend docstring for `_get_device_update_edus_by_remote`
reivilibre Jan 11, 2022
d17de19
Comment about `_get_device_update_edus_by_remote` length guarantee
reivilibre Jan 11, 2022
a306a89
Add types for `_get_device_updates_by_remote_txn` and amend docstring
reivilibre Jan 11, 2022
cc8904e
Create variables for if conditions
reivilibre Jan 11, 2022
2cf1691
Use extracted variable in if conditions
reivilibre Jan 11, 2022
aceb240
Calculate the remaining length budget
reivilibre Jan 11, 2022
451b4ff
Check for 2 free slots before adding a cross-signing key update
reivilibre Jan 11, 2022
34ae0ba
Add FIXME note that this complication can be removed when we cut out …
reivilibre Jan 12, 2022
62e8e45
Newsfile
reivilibre Jan 12, 2022
2107d12
Add a test to ensure cross-signing key updates don't blow the limit
reivilibre Jan 12, 2022
6643b94
Apply suggestions from code review
reivilibre Jan 13, 2022
8b01179
Use JsonDict type for EDUs
reivilibre Jan 13, 2022
b5dc363
Commentsmithing
reivilibre Jan 13, 2022
0476aee
Check there are no more updates left after the end of the test
reivilibre Jan 13, 2022
57b3601
Add FIXME note about discarding OpenTracing contexts
reivilibre Jan 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/11730.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix a bug introduced in Synapse v1.50.0rc1 whereby outbound federation could fail because too many EDUs were produced for device updates.