Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Remove fixed and flakey tests from the sytest blacklist #10788

Merged
DMRobertson merged 8 commits into from
Sep 10, 2021
Merged

Remove fixed and flakey tests from the sytest blacklist #10788

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
637bc1e
Nuke the blacklist files to see what succeeds!
Sep 9, 2021
d196f9f
Changelog
Sep 9, 2021
2b3fba5
I think these things all need blacklisting
Sep 9, 2021
922ece9
Commit to unblacklisting test for fixed issue
Sep 9, 2021
a62393e
Re-blacklist something that's known to be flakey.
Sep 9, 2021
c048d64
Revert "Re-blacklist something that's known to be flakey."
Sep 9, 2021
bb5a60d
Unblacklist tests that aren't consistently failing
Sep 9, 2021
17fade8
Update changelog
Sep 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions .ci/worker-blacklist
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,2 @@
# This file serves as a blacklist for SyTest tests that we expect will fail in
# Synapse when run under worker mode. For more details, see sytest-blacklist.

Can re-join room if re-invited

# new failures as of https://github.com/matrix-org/sytest/pull/732
Device list doesn't change if remote server is down

# https://buildkite.com/matrix-dot-org/synapse/builds/6134#6f67bf47-e234-474d-80e8-c6e1868b15c5
Server correctly handles incoming m.device_list_update
1 change: 1 addition & 0 deletions changelog.d/10788.misc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Remove fixed and flakey tests from the sytest-blacklist.
11 changes: 1 addition & 10 deletions sytest-blacklist
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# This file serves as a blacklist for SyTest tests that we expect will fail in
# Synapse.
# Synapse. This doesn't include flakey tests---better to deflake them instead.
#
# Each line of this file is scanned by sytest during a run and if the line
# exactly matches the name of a test, it will be marked as "expected fail",
Expand All @@ -9,9 +9,6 @@
# Test names are encouraged to have a bug accompanied with them, serving as an
# explanation for why the test has been excluded.

# Blacklisted due to https://github.com/matrix-org/synapse/issues/1679
Remote room members also see posted message events

# Blacklisted due to https://github.com/matrix-org/synapse/issues/2065
Guest users can accept invites to private rooms over federation

Expand All @@ -24,12 +21,6 @@ Newly created users see their own presence in /initialSync (SYT-34)
# Blacklisted due to https://github.com/matrix-org/synapse/issues/1396
Should reject keys claiming to belong to a different user

# Blacklisted due to https://github.com/matrix-org/synapse/issues/1531
Enabling an unknown default rule fails with 404

# Blacklisted due to https://github.com/matrix-org/synapse/issues/1663
New federated private chats get full presence information (SYN-115)

# Blacklisted due to https://github.com/matrix-org/matrix-doc/pull/2314 removing
# this requirement from the spec
Inbound federation of state requires event_id as a mandatory paramater
Expand Down