This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Replace the synapse.app.appservice and synapse.app.user_dir worker types with more flexible config options#10616
Closed
anoadragon453 wants to merge 3 commits intodevelopfrom
Closed
Replace the synapse.app.appservice and synapse.app.user_dir worker types with more flexible config options#10616anoadragon453 wants to merge 3 commits intodevelopfrom
synapse.app.appservice and synapse.app.user_dir worker types with more flexible config options#10616anoadragon453 wants to merge 3 commits intodevelopfrom
Conversation
…n only Also clean up the worker sample configuration section a little bit.
synapse.app.appservice and synapse.app.user_dir worker types with more flexible config options
Member
|
this looks very similar to #11450... is it still alive? |
Contributor
Member
Author
|
Oh! Yes, this is old, old, old and can be closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First phase of #10441.
This PR replaces the logic that decides which worker to notify appservices or update the user directory. Originally, you would have to set
notify_appservices/update_user_directorytofalse, as well as setting theworker_typeconfig option for each worker.Now we follow the same format as
run_background_tasks_on, where we have a single config option which both the main process and worker processes read from. If the value matches the worker's current name, then that worker will carry out that task.TODO: