Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Replace the synapse.app.appservice and synapse.app.user_dir worker types with more flexible config options#10616

Closed
anoadragon453 wants to merge 3 commits intodevelopfrom
anoa/worker_types_phase_1
Closed

Replace the synapse.app.appservice and synapse.app.user_dir worker types with more flexible config options#10616
anoadragon453 wants to merge 3 commits intodevelopfrom
anoa/worker_types_phase_1

Conversation

@anoadragon453
Copy link
Copy Markdown
Member

@anoadragon453 anoadragon453 commented Aug 16, 2021

First phase of #10441.

This PR replaces the logic that decides which worker to notify appservices or update the user directory. Originally, you would have to set notify_appservices / update_user_directory to false, as well as setting the worker_type config option for each worker.

Now we follow the same format as run_background_tasks_on, where we have a single config option which both the main process and worker processes read from. If the value matches the worker's current name, then that worker will carry out that task.

TODO:

  • Update Complement worker config generator script
  • Make a note in UPGRADE.rst - this is currently a backwards-incompatible change
  • Update worker documentation

@anoadragon453 anoadragon453 changed the title Move notify_appservices from worker type / config option to config option only Replace the synapse.app.appservice and synapse.app.user_dir worker types with more flexible config options Aug 17, 2021
@richvdh
Copy link
Copy Markdown
Member

richvdh commented Feb 15, 2022

this looks very similar to #11450... is it still alive?

@dklimpel
Copy link
Copy Markdown
Contributor

Is this replaced by #12446 and #12654 ?

@anoadragon453
Copy link
Copy Markdown
Member Author

Oh! Yes, this is old, old, old and can be closed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants