Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Remove references to BuildKite in favour of GitHub Actions #10573

Merged
DMRobertson merged 14 commits into from
Aug 12, 2021
Merged

Remove references to BuildKite in favour of GitHub Actions #10573

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
8da9e3c
Move test_old_deps.sh to new ci dir
DMRobertson Aug 10, 2021
03fb99a
check-newsfragment: pass pr number explicitly
DMRobertson Aug 10, 2021
3d67b8c
Move sytest worker-blacklist to ci directory
DMRobertson Aug 10, 2021
c5988a8
Remove unused BUILDKITE_BRANCH env var
DMRobertson Aug 10, 2021
58e5da5
Remove buildkite from portdb CI tests
DMRobertson Aug 10, 2021
c0ebdfc
Kill off the .buildkite dir completely
DMRobertson Aug 10, 2021
b924a5c
Add changelog entry and signoff
DMRobertson Aug 10, 2021
33ef86a
Rename ci to .ci
Aug 11, 2021
6fcc3e0
Teach MANIFEST and tox about ci->.ci
Aug 11, 2021
cb5976e
set TOP in sytest containers
Aug 11, 2021
92a8e68
Missed another ci->.ci
Aug 11, 2021
314a739
Also rename in lint.sh
Aug 12, 2021
74fcd5a
portdb also uses coverage, so provide $TOP there
Aug 12, 2021
8785289
Remove buildkite-era comment
Aug 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .buildkite/.env
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ BUILDKITE_JOB_ID
BUILDKITE_BUILD_URL
BUILDKITE_PROJECT_SLUG
BUILDKITE_COMMIT
BUILDKITE_PULL_REQUEST
BUILDKITE_TAG
CODECOV_TOKEN
TRIAL_FLAGS
35 changes: 0 additions & 35 deletions .buildkite/merge_base_branch.sh
View file
Open in desktop

This file was deleted.

6 changes: 2 additions & 4 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,9 @@ jobs:
fetch-depth: 0
- uses: actions/setup-python@v2
- run: pip install tox
- name: Patch Buildkite-specific test script

@DMRobertson DMRobertson Aug 10, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't sure what @callahad had in mind here (see line 41 above) for simplifying the check-newsfragment script.

Aside: I can't seem to leave a comment on line 41 because(?) it's not part of the diff hunk?

@richvdh richvdh Aug 11, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside: I can't seem to leave a comment on line 41 because(?) it's not part of the diff hunk?

welcome to github PR review!

@richvdh richvdh Aug 11, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... of course you can make it part of the diff hunk by removing the comment about Buildkite :). I think you've done is all that was needed here.

I'm not sure how it relates to the issues about checkout though. I guess they are meant to be a separate comment.

@richvdh richvdh Aug 12, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please can you remove the comment at line 41?

run: |
sed -i -e 's/\$BUILDKITE_PULL_REQUEST/${{ github.event.number }}/' \
scripts-dev/check-newsfragment
- run: scripts-dev/check-newsfragment
env:
PULL_REQUEST_NUMBER: ${{ github.event.number }}
Comment thread
DMRobertson marked this conversation as resolved.

lint-sdist:
runs-on: ubuntu-latest
Expand Down
2 changes: 1 addition & 1 deletion scripts-dev/check-newsfragment
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ set -e
git remote set-branches --add origin develop
git fetch -q origin develop

pr="$BUILDKITE_PULL_REQUEST"
pr="$PULL_REQUEST_NUMBER"

# if there are changes in the debian directory, check that the debian changelog
# has been updated
Expand Down