Incorrect notications from intentional mentions which include @room?

[clokep]

Support for intentional mentions was apparently stabilized in #15520 / Synapse v1.86.0rc1, right? Yet, when I just sent a message with @room in a code block, which Element Web correctly translated to m.mentions being set but without the room flag, people still got notified.

The spec says that the push rule for @room should only be enabled if the event does not have an m.mentions property.

Originally posted by @jplatte in #15661 (comment)

[clokep]

Looking at the code it doesn't seem like Synapse would generate this notification:

synapse/rust/src/push/evaluator.rs

Lines 170 to 178 in 5946074

	// For backwards-compatibility the legacy mention rules are disabled
	// if the event contains the 'm.mentions' property.
	if self.has_mentions
	&& (rule_id == "global/override/.m.rule.contains_display_name"
	|| rule_id == "global/content/.m.rule.contains_user_name"
	|| rule_id == "global/override/.m.rule.roomnotif")
	{
	continue;
	}

Are the people getting notified on updated clients that understand intentional mentions? Is the notification coming from the server or from the client?

[jplatte]

Thanks. I really just wrote that comment to get a quick "this should work - probably an EleWeb issue" or "oh yeah we didn't actually implement that part of the spec yet". Based on what you wrote above it's the former.

[clokep]

My guess would be either:

1. Someone is running an old Element Web (or other client that doesn't implement the new rules);
2. A bug in a client

It definitely could be a bug in Synapse, but we do also test this behavior:

synapse/tests/push/test_bulk_push_rule_evaluator.py

Lines 372 to 382 in 9ec3da0

	# The legacy push rule should not mention if the mentions field exists.
	self.assertFalse(
	self._create_and_process(
	bulk_evaluator,
	{
	"body": "@room",
	"msgtype": "m.text",
	EventContentFields.MENTIONS: {},
	},
	)
	)