Support shorter tokens used with authentication#3
Merged
babolivier merged 33 commits intomainfrom Aug 17, 2021
Merged
Conversation
richvdh
requested changes
May 6, 2021
Member
richvdh
left a comment
richvdh
left a comment
There was a problem hiding this comment.
looks generally plausible, but I think there is probably some architectural work to be done between here and matrix-org/synapse#9884.
(Sorry, some of my comments here are more relevant to this plugin as a whole than this PR, but it was a handy place to put them.)
callahad
reviewed
May 13, 2021
richvdh
reviewed
Jul 5, 2021
Member
richvdh
left a comment
richvdh
left a comment
There was a problem hiding this comment.
sorry to be a pain in the ass, but how difficult would it be to split this up into separate PRs for (1) update to the new module api and (2) add new functionality?
Contributor
Author
|
You're right, it'd probably be a bit better, this PR has gone a bit out of control size and scope wise. |
Contributor
Author
richvdh
requested changes
Jul 28, 2021
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
…l-account-validity into babolivier/token
richvdh
approved these changes
Aug 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new
send_linksconfiguration option which defines whether to send links for the user to click in renewal emails, and defaults totrue. If set tofalse, only the renewal token is sent, which is expected to be copied by the user into a compatible client, which would then send it to the homeserver in an authenticated request (which means we don't need to ensure these shorter tokens are unique across all of the users).Based off #4