Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Update the DomainRuleChecker module to the new callback and API#111

Closed
babolivier wants to merge 7 commits intobabolivier/update_module_apifrom
babolivier/update_domain_rule_checker
Closed

Update the DomainRuleChecker module to the new callback and API#111
babolivier wants to merge 7 commits intobabolivier/update_module_apifrom
babolivier/update_domain_rule_checker

Conversation

@babolivier
Copy link
Copy Markdown
Contributor

Depends on #110 - I've made this PR target #110's branch to make the diff more readable.

Note to reviewer:

Commits should be reviewable independently. Ideally the 1st commit should be its own PR, but it makes the DomainRuleChecker CI go red so I thought it made more sense to have it in here.

Note to ops:

When deploying a Synapse version including this PR, a Synapse config change is required. All that's needed should be to move the config for the DomainRuleChecker from the spam_checker section to the modules one of the configuration file, since I also had to port the module to the new system. So this means this bit of configuration:

spam_checker:
    - module: synapse.rulecheck.DomainRuleChecker
      config: {...}

Should become:

modules:
    - module: synapse.rulecheck.DomainRuleChecker
      config: {...}

Note that this PR also removes support for the now useless can_only_create_one_to_one_rooms config option, but Synapse or the module won't fail if this option is kept around.

Bring other callbacks to party with mainline, and fixup code calling to
the various callbacks.
Because we already do these checks with RoomAccessRules
@babolivier babolivier requested a review from a team November 8, 2021 16:21
@babolivier
Copy link
Copy Markdown
Contributor Author

This turned out to be a mess, so I've reopened #108

@babolivier babolivier closed this Nov 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant