This repository was archived by the owner on Jul 21, 2025. It is now read-only.
Make sydent.config pass mypy --strict#431
Merged
DMRobertson merged 3 commits intomainfrom Oct 19, 2021
Merged
Conversation
clokep
approved these changes
Oct 18, 2021
| """ | ||
|
|
||
| def __init__(self): | ||
| def __init__(self) -> None: |
Member
There was a problem hiding this comment.
Is this needed? (Does strict require this?)
Contributor
Author
There was a problem hiding this comment.
It's needed if there are no arguments other than self. Some discussion here: matrix-org/synapse#10892 (comment)
Contributor
Author
There was a problem hiding this comment.
And this is from the option disallow-untyped-defswhich is implied by--strict`.
Member
|
It seems linting is failing here though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was easier than I expected!
Part of #414.