Add basic support for parsing matrix-URIs (MSC2312)#234
Open
Unkn0wnCat wants to merge 5 commits intomatrix-org:mainfrom
Open
Add basic support for parsing matrix-URIs (MSC2312)#234Unkn0wnCat wants to merge 5 commits intomatrix-org:mainfrom
Unkn0wnCat wants to merge 5 commits intomatrix-org:mainfrom
Conversation
Author
|
Update: I've changed the links in my description to include the preview link provided by Netlify CI. You can directly test my fork at https://deploy-preview-234--matrix-to.netlify.app/ |
Author
|
Example code for registering matrix.to as a matrix:-protocol-handler with this PR: navigator.registerProtocolHandler("matrix",
"https://deploy-preview-234--matrix-to.netlify.app/#/%s",
"Matrix");You can try it out by copying it into your browser console (Tested on Firefox 92.0.1) |
Author
|
After talking to @DanilaFe, I'll now be working on implementing https://github.com/matrix-org/matrix-uri-parser-js into Matrix.to instead of doing something completely new. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello all,
This pull request implements basic support for processing matrix-URIs as defined in matrix-org/matrix-spec-proposals#2312.
Included in this pull request:
Note that the "matrix:"-prefix is optional. Links like https://deploy-preview-234--matrix-to.netlify.app/#/u/kevin:1in1.net also work!
See also: #205, This PR would work great in conjunction with #223
Hope this helps, let me know if you'd like something changed or if there is something I've overlooked!
-- Kevin