This repository was archived by the owner on Mar 7, 2025. It is now read-only.
Update the use of complete_sso_login with changes in Synapse.#9
Merged
Update the use of complete_sso_login with changes in Synapse.#9
Conversation
anoadragon453
approved these changes
Apr 17, 2020
Member
anoadragon453
left a comment
anoadragon453
left a comment
There was a problem hiding this comment.
LGTM assuming CI is happy once #10 is merged.
clokep
force-pushed
the
clokep/async-sso-login
branch
from
cbf599c to
9d70341
Compare
Member
Author
|
Rebased this, let's see how it goes... |
clokep
force-pushed
the
clokep/async-sso-login
branch
from
9d70341 to
938507e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates for the changes in matrix-org/synapse#7240. The corresponding Synapse changes are backwards compatible so we'll want to deploy this after Synapse is updated. If we need this code to be backwards compatible that should be doable, but I'm unsure if it is a requirement.
Tests are fixed in #10