Skip to content

Specify MSC3882: Using an existing session to log in another#1530

Merged
turt2live merged 7 commits intomainfrom
travis/msc3882/1
May 23, 2023
Merged

Specify MSC3882: Using an existing session to log in another#1530
turt2live merged 7 commits intomainfrom
travis/msc3882/1

Conversation

@turt2live
Copy link
Copy Markdown
Member

@turt2live turt2live commented May 19, 2023

@turt2live turt2live added the release-blocker Blocks the next release from happening label May 19, 2023
@turt2live turt2live marked this pull request as ready for review May 19, 2023 04:11
@turt2live turt2live requested a review from a team as a code owner May 19, 2023 04:11
@turt2live turt2live requested review from dbkr and richvdh May 19, 2023 04:12
Copy link
Copy Markdown
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good otherwise

@@ -0,0 +1 @@
[`POST /_matrix/client/v3/login/get_token`](/client-server-api/#post_matrixclientv3loginget_token). No newline at end of file
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't aware of this type of newsfragment being a thing. We have other new endpoints (POST /_matrix/media/v1/create etc) which haven't had one of these...

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea... They'll be caught as part of "changelog normalization" in the release process.

turt2live and others added 3 commits May 19, 2023 08:20
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
@turt2live turt2live requested a review from richvdh May 19, 2023 18:34
Copy link
Copy Markdown
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm otherwise

Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-blocker Blocks the next release from happening

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants