Add spec for MSC2449: Require users to have visibility on an event when submitting reports#1517
Conversation
anoadragon453
left a comment
anoadragon453
left a comment
There was a problem hiding this comment.
Looks good overall! Just a few nitpicks looking back and forth between the MSC.
| summary: Reports an event as inappropriate. You must have permission to | ||
| retrieve this event e.g. by being a member in the room for this event. |
There was a problem hiding this comment.
This feels a bit hand-wavy. The requirements laid out by MSC2249 are that you must be currently joined to the room that the reported event is in.
| The server MUST verify that the user has permission to view the event | ||
| before accepting a report. |
There was a problem hiding this comment.
Again, this feels looser than what the MSC stated, which is that the reporter must currently be joined to the room that the reported event is in. Perhaps:
| The server MUST verify that the user has permission to view the event | |
| before accepting a report. | |
| The server MUST verify that the user reporting the event is currently | |
| joined to the room the event is in before accepting a report. |
There was a problem hiding this comment.
further, a changed-in annotation:
| The server MUST verify that the user has permission to view the event | |
| before accepting a report. | |
| {{< changed-in v="1.7" >}} The server MUST verify that the user | |
| reporting the event is currently joined to the room the event is | |
| in before accepting a report. |
turt2live
left a comment
turt2live
left a comment
There was a problem hiding this comment.
plus what anoa said - otherwise lgtm, thank you!
| The server MUST verify that the user has permission to view the event | ||
| before accepting a report. |
There was a problem hiding this comment.
further, a changed-in annotation:
| The server MUST verify that the user has permission to view the event | |
| before accepting a report. | |
| {{< changed-in v="1.7" >}} The server MUST verify that the user | |
| reporting the event is currently joined to the room the event is | |
| in before accepting a report. |
turt2live
left a comment
turt2live
left a comment
There was a problem hiding this comment.
otherwise lgtm.
The MSC was very clear that the condition was being joined to the room, not visibility of the event - my comments are to try and bring that in line.
It also looks like you have a couple unreviewed threads from @anoadragon453 to look at 😇 (I've added to them as well)
|
I plan to take over the maintenance of this PR in the author's place. |
Co-authored-by: Travis Ralston <[email protected]>
now how did that happen
anoadragon453
left a comment
anoadragon453
left a comment
There was a problem hiding this comment.
This PR has been updated with changes from review.
it wasn't displaying correctly in the rendered spec otherwise
Co-authored-by: Travis Ralston <[email protected]>
|
Oh, apparently I forgot I wasn't working on this...sorry @anoadragon453! |
3 participants
matrix-org/matrix-spec-proposals#2249
Preview: https://pr1517--matrix-spec-previews.netlify.app