Skip to content

Remove keyId from the server keys endpoints#1350

Merged
turt2live merged 4 commits intomatrix-org:mainfrom
zecakeh:remove-keyid
Jan 3, 2023
Merged

Remove keyId from the server keys endpoints#1350
turt2live merged 4 commits intomatrix-org:mainfrom
zecakeh:remove-keyid

Conversation

@zecakeh
Copy link
Copy Markdown
Contributor

@zecakeh zecakeh commented Nov 17, 2022 •
edited by github-actions bot
Loading

Spec PR for MSC3938.

This is a prerequisite for #1310.

Signed-off-by: Kévin Commaille [email protected]

Preview: https://pr1350--matrix-spec-previews.netlify.app

@zecakeh
Remove keyId from the server keys endpoints
4e69140 
It has been deprecated forever.
Besides, the OpenAPI 3 spec doesn't allow optional path parameters.

Signed-off-by: Kévin Commaille <[email protected]>
@zecakeh zecakeh requested a review from a team as a code owner November 17, 2022 17:12
@zecakeh
Add newsfragment
aa2ca7c 
Signed-off-by: Kévin Commaille <[email protected]>
@zecakeh zecakeh mentioned this pull request Nov 17, 2022
Merged
4 tasks
@zecakeh
Fix broken link
f898932 
Signed-off-by: Kévin Commaille <[email protected]>
turt2live
turt2live previously requested changes Nov 17, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deprecated endpoints require an MSC to remove them.

@turt2live
Copy link
Copy Markdown
Member

turt2live commented Nov 17, 2022

What we've done in the past is just copy/pasted the endpoint definition, as annoying as that is.

@richvdh
Copy link
Copy Markdown
Member

richvdh commented Nov 18, 2022

Deprecated endpoints require an MSC to remove them.

I mean, really? Isn't the fact that they are deprecated enough of an indication that if people care about them they need to make a case to undeprecate them?

@turt2live
Copy link
Copy Markdown
Member

turt2live commented Nov 18, 2022

Not according to our specified deprecation policy: https://spec.matrix.org/v1.5/#deprecation-policy

@richvdh
Copy link
Copy Markdown
Member

richvdh commented Nov 18, 2022

ugh, what a pain in the ass. I think we should revise that.

@turt2live
Copy link
Copy Markdown
Member

turt2live commented Nov 18, 2022

it'd only take an MSC 😇

I'm fairly opposed to changing the policy here, but that's a discussion for elsewhere.

@richvdh
Copy link
Copy Markdown
Member

richvdh commented Nov 22, 2022

I've opened matrix-org/matrix-spec-proposals#3938.

@zecakeh
Mention MSC3938 in newfragment
2bf6d1d 
Signed-off-by: Kévin Commaille <[email protected]>
@zecakeh
Copy link
Copy Markdown
Contributor Author

zecakeh commented Dec 26, 2022

I updated the description and changelog entry to mention MSC3938.

@uhoreg uhoreg mentioned this pull request Dec 26, 2022
Merged
@uhoreg uhoreg requested a review from a team December 26, 2022 23:04
turt2live
turt2live approved these changes Jan 3, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@turt2live turt2live merged commit 9e45037 into matrix-org:main Jan 3, 2023
This was referenced Jan 3, 2023
Closed
Closed
@zecakeh zecakeh deleted the remove-keyid branch January 8, 2023 11:04
clokep pushed a commit to clokep/matrix-spec that referenced this pull request May 3, 2023
@zecakeh @clokep
Remove keyId from the server keys endpoints (matrix-org#1350)
f441c15 
* Remove keyId from the server keys endpoints

It has been deprecated forever.
Besides, the OpenAPI 3 spec doesn't allow optional path parameters.

Signed-off-by: Kévin Commaille <[email protected]>

* Add newsfragment

Signed-off-by: Kévin Commaille <[email protected]>

* Fix broken link

Signed-off-by: Kévin Commaille <[email protected]>

* Mention MSC3938 in newfragment

Signed-off-by: Kévin Commaille <[email protected]>

Signed-off-by: Kévin Commaille <[email protected]>
@S7evinK S7evinK mentioned this pull request Oct 2, 2023
Open
11 tasks
@Johennes Johennes mentioned this pull request Jun 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@turt2live turt2live turt2live approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zecakeh @turt2live @richvdh