Skip to content

Copy room type on upgrade too #1198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
turt2live merged 1 commit into from
Aug 3, 2022
Merged

Copy room type on upgrade too #1198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelogs/client_server/newsfragments/1198.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Copy a room's `type` when upgrading it, as per [MSC3818](https://github.com/matrix-org/matrix-spec-proposals/pull/3818).
7 changes: 5 additions & 2 deletions content/client-server-api/modules/room_upgrades.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,11 @@ server:
1. Checks that the user has permission to send `m.room.tombstone`
events in the room.

2. Creates a replacement room with a `m.room.create` event containing a
`predecessor` field and the applicable `room_version`.
2. {{< changed-in v="1.4" >}} Creates a replacement room with a `m.room.create` event containing a
`predecessor` field, the applicable `room_version`, and a `type` field
which is copied from the `predecessor` room. If no `type` is set on the
previous room, no `type` is specified on the new room's create event
either.

3. Replicates transferable state events to the new room. The exact
details for what is transferred is left as an implementation detail,
Expand Down