MSC3912: Redaction of related events by babolivier · Pull Request #3912 · matrix-org/matrix-spec-proposals

babolivier · 2022-10-18T11:58:15Z

Rendered

Synapse implementation:
- Implement MSC3912: Relation-based redactions synapse#14260
- Add a catch-all * to the supported relation types when redacting synapse#15705

Client side implementation:

Web - JS SDK implementation:
- Implement MSC3912: Relation-based redactions matrix-js-sdk#2954
- Update MSC3912 implementation to use with_rel_type instead of with_relations matrix-js-sdk#3420
iOS SDK implementation:
- Implement MSC3912: redaction with relations matrix-ios-sdk#1688
- MSC3912 implementation: stable property with_relations has been renamed with_rel_types matrix-ios-sdk#1793
Android implementation:
- Implement MSC3912 to delete server side all the data of a deleted voice broadcast element-hq/element-android#7988
- Update MSC3912 implementation: Redaction of related events element-hq/element-android#8532

proposals/3912-relation-based-redaction.md

… implems

proposals/3912-relation-based-redaction.md

@ashfame

Synapse 1.72.0 (2022-11-22) =========================== Please note that Synapse now only supports PostgreSQL 11+, because PostgreSQL 10 has reached end-of-life, c.f. our [Deprecation Policy](https://github.com/matrix-org/synapse/blob/develop/docs/deprecation_policy.md). Bugfixes -------- - Update forgotten references to legacy metrics in the included Grafana dashboard. ([\matrix-org#14477](matrix-org#14477)) Synapse 1.72.0rc1 (2022-11-16) ============================== Features -------- - Add experimental support for [MSC3912](matrix-org/matrix-spec-proposals#3912): Relation-based redactions. ([\matrix-org#14260](matrix-org#14260)) - Build Debian packages for Ubuntu 22.10 (Kinetic Kudu). ([\matrix-org#14396](matrix-org#14396)) - Add an [Admin API](https://matrix-org.github.io/synapse/latest/usage/administration/admin_api/index.html) endpoint for user lookup based on third-party ID (3PID). Contributed by @ashfame. ([\matrix-org#14405](matrix-org#14405)) - Faster joins: include heroes' membership events in the partial join response, for rooms without a name or canonical alias. ([\matrix-org#14442](matrix-org#14442)) Bugfixes -------- - Faster joins: do not block creation of or queries for room aliases during the resync. ([\matrix-org#14292](matrix-org#14292)) - Fix a bug introduced in Synapse 1.64.0rc1 which could cause log spam when fetching events from other homeservers. ([\matrix-org#14347](matrix-org#14347)) - Fix a bug introduced in 1.66 which would not send certain pushrules to clients. Contributed by Nico. ([\matrix-org#14356](matrix-org#14356)) - Fix a bug introduced in v1.71.0rc1 where the power level event was incorrectly created during initial room creation. ([\matrix-org#14361](matrix-org#14361)) - Fix the refresh token endpoint to be under /r0 and /v3 instead of /v1. Contributed by Tulir @ Beeper. ([\matrix-org#14364](matrix-org#14364)) - Fix a long-standing bug where Synapse would raise an error when encountering an unrecognised field in a `/sync` filter, instead of ignoring it for forward compatibility. ([\matrix-org#14369](matrix-org#14369)) - Fix a background database update, introduced in Synapse 1.64.0, which could cause poor database performance. ([\matrix-org#14374](matrix-org#14374)) - Fix PostgreSQL sometimes using table scans for queries against the `event_search` table, taking a long time and a large amount of IO. ([\matrix-org#14409](matrix-org#14409)) - Fix rendering of some HTML templates (including emails). Introduced in v1.71.0. ([\matrix-org#14448](matrix-org#14448)) - Fix a bug introduced in Synapse 1.70.0 where the background updates to add non-thread unique indexes on receipts could fail when upgrading from 1.67.0 or earlier. ([\matrix-org#14453](matrix-org#14453)) Updates to the Docker image --------------------------- - Add all Stream Writer worker types to `configure_workers_and_start.py`. ([\matrix-org#14197](matrix-org#14197)) - Remove references to legacy worker types in the multi-worker Dockerfile. ([\matrix-org#14294](matrix-org#14294)) Improved Documentation ---------------------- - Upload documentation PRs to Netlify. ([\matrix-org#12947](matrix-org#12947), [\matrix-org#14370](matrix-org#14370)) - Add addtional TURN server configuration example based on [eturnal](https://github.com/processone/eturnal) and adjust general TURN server doc structure. ([\matrix-org#14293](matrix-org#14293)) - Add example on how to load balance /sync requests. Contributed by [aceArt](https://aceart.de). ([\matrix-org#14297](matrix-org#14297)) - Edit sample Nginx reverse proxy configuration to use HTTP/1.1. Contributed by Brad Jones. ([\matrix-org#14414](matrix-org#14414)) Deprecations and Removals ------------------------- - Remove support for PostgreSQL 10. ([\matrix-org#14392](matrix-org#14392), [\matrix-org#14397](matrix-org#14397)) Internal Changes ---------------- - Run unit tests against Python 3.11. ([\matrix-org#13812](matrix-org#13812)) - Add TLS support for generic worker endpoints. ([\matrix-org#14128](matrix-org#14128), [\matrix-org#14455](matrix-org#14455)) - Switch to a maintained action for installing Rust in CI. ([\matrix-org#14313](matrix-org#14313)) - Add override ability to `complement.sh` command line script to request certain types of workers. ([\matrix-org#14324](matrix-org#14324)) - Enabling testing of [MSC3874](matrix-org/matrix-spec-proposals#3874) (filtering of `/messages` by relation type) in complement. ([\matrix-org#14339](matrix-org#14339)) - Concisely log a failure to resolve state due to missing `prev_events`. ([\matrix-org#14346](matrix-org#14346)) - Use a maintained Github action to install Rust. ([\matrix-org#14351](matrix-org#14351)) - Cleanup old worker datastore classes. Contributed by Nick @ Beeper (@Fizzadar). ([\matrix-org#14375](matrix-org#14375)) - Test against PostgreSQL 15 in CI. ([\matrix-org#14394](matrix-org#14394)) - Remove unreachable code. ([\matrix-org#14410](matrix-org#14410)) - Clean-up event persistence code. ([\matrix-org#14411](matrix-org#14411)) - Update docstring to clarify that `get_partial_state_events_batch` does not just give you completely arbitrary partial-state events. ([\matrix-org#14417](matrix-org#14417)) - Fix mypy errors introduced by bumping the locked version of `attrs` and `gitpython`. ([\matrix-org#14433](matrix-org#14433)) - Make Dependabot only bump Rust deps in the lock file. ([\matrix-org#14434](matrix-org#14434)) - Fix an incorrect stub return type for `PushRuleEvaluator.run`. ([\matrix-org#14451](matrix-org#14451)) - Improve performance of `/context` in large rooms. ([\matrix-org#14461](matrix-org#14461))

proposals/3912-relation-based-redaction.md

@ashfame

Synapse 1.72.0 (2022-11-22) =========================== Please note that Synapse now only supports PostgreSQL 11+, because PostgreSQL 10 has reached end-of-life, c.f. our [Deprecation Policy](https://github.com/matrix-org/synapse/blob/develop/docs/deprecation_policy.md). Features -------- - Add experimental support for [MSC3912](matrix-org/matrix-spec-proposals#3912): Relation-based redactions. ([\#14260](matrix-org/synapse#14260)) - Build Debian packages for Ubuntu 22.10 (Kinetic Kudu). ([\#14396](matrix-org/synapse#14396)) - Add an [Admin API](https://matrix-org.github.io/synapse/latest/usage/administration/admin_api/index.html) endpoint for user lookup based on third-party ID (3PID). Contributed by @ashfame. ([\#14405](matrix-org/synapse#14405)) - Faster joins: include heroes' membership events in the partial join response, for rooms without a name or canonical alias. ([\#14442](matrix-org/synapse#14442)) Deprecations and Removals ------------------------- - Remove support for PostgreSQL 10. ([\#14392](matrix-org/synapse#14392), [\#14397](matrix-org/synapse#14397))

weeman1337 · 2022-12-07T10:18:01Z

I am currently working on adding this to the Matrix JS SDK.

This is an extension to an existing endpoint. The same would probably apply to the function call in the SDK: Current plan is to add an option tot he redact call. How do you think the SDK should behave in this case?

Send the event anyway. Means the caller is responsible to check for server side support before.
Check for server side support on redaction with with_relations and raise an error if no support.

babolivier · 2022-12-07T10:36:02Z

Hey @weeman1337, this is probably something the Element Web team would be better positioned to answer (since it's an implementation detail), but I would expect clients to check for server support and only show the feature to the user if there is server-side support for it.
Also, please use threads to comment on MSCs (by clicking on a line in the diff), since it makes the timeline more readable 🙂

proposals/3912-relation-based-redaction.md

- Update title - Correct the provided example, and clarify some use cases

…n must be updated - rename the new property `with_relations` with `with_rel_types` (to prevent us from introducing a new term ("relations") to refer to event relationships). Only the stable name is changed, we keep the existing unstable one. - introduce a catch-all `"*"` value, which if found in the list means "any relation type"

giomfo · 2023-05-29T13:59:21Z

@richvdh @turt2live FYI I resolved all the pending discussions on this MSC with my 2 last commits.
I filed a new issue on each platform to update the current implementation according to the changes introduced by the last commit

synapse: Update MSC3912 implementation: Redaction of related events synapse#15687
web: Update MSC3912 implementation: Redaction of related events element-hq/element-web#25471
ios: Update MSC3912 implementation: Redaction of related events element-hq/element-ios#7563
android: Update MSC3912 implementation: Redaction of related events element-hq/element-android#8481

richvdh · 2023-05-31T10:37:41Z

proposals/3912-relation-based-redaction.md

+If an event that matches the redaction criteria comes down federation after
+redaction requests has completed, the server must attempt to redact it on behalf
+of the redaction request's sender.


The Synapse PR referenced in the PR description (matrix-org/synapse#14260) says:

This implementation is lacking a way to keep watch for incoming events that match the redaction criteria after the redaction request finishes, that'll come in a separate PR.

Is there any indication that this second part has happened? If not, then I don't think that counts as a complete implementation of the MSC and we should remove those parts from the MSC.

I would let the backend team think about this use case before deciding to remove or not this part (some details)

richvdh · 2023-05-31T11:13:40Z

proposals/3912-relation-based-redaction.md

+Homeservers which support this MSC should indicate it by adding
+`org.matrix.msc3912` and `org.matrix.msc3912.stable` in the response to `GET
+/_matrix/client/versions` requests.


presumably there is some difference between org.matrix.msc3912 and org.matrix.msc3912.stable? Please make it explicit what that difference is.

(I think https://github.com/matrix-org/matrix-spec-proposals/blob/main/proposals/3827-space-explore.md#unstable-prefix does a decent job of this -- in particular it explains what clients should do at each stage)

are we sure we need org.matrix.msc3912.stable ? We should only spec a "stable" unstable_feature if we absolutely need to get this feature into widespread use before homeserver implementations support the spec version which includes this.

FYI I decided to remove the "stable" flag (see 1b3176c)
I consider the homeservers will still support the unstable attribute org.matrix.msc3912.with_relations until the clients are updated to check the presence of the spec version, that supports the MSC

proposals/3912-relation-based-redaction.md

Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>

MSCXXXX: Relation-based redactions

107bbe3

babolivier changed the title ~~MSCXXXX: Relation-based redactions~~ MSC3912: Relation-based redactions Oct 18, 2022

babolivier added 2 commits October 18, 2022 12:59

MSC number

09cf8c0

Typo

f966734

clokep reviewed Oct 18, 2022

View reviewed changes

proposals/3912-relation-based-redaction.md Show resolved Hide resolved

uhoreg added proposal A matrix spec change proposal client-server Client-Server API kind:maintenance MSC which clarifies/updates existing spec needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. labels Oct 18, 2022

turt2live added the hacktoberfest-accepted label Oct 18, 2022

Add missing alternative

8a21053

babolivier mentioned this pull request Oct 19, 2022

Implement MSC3912: Relation-based redactions matrix-org/synapse#14231

Open

2 tasks

FSG-Cat reviewed Oct 19, 2022

View reviewed changes

proposals/3912-relation-based-redaction.md Outdated Show resolved Hide resolved

babolivier added 4 commits October 20, 2022 10:38

Add mention of MSC2244, and tweak the MSC to make it easier on server…

85b270a

… implems

Typo

9fd9f64

Wrap

b2ec847

Wrap more

84a20ed

babolivier commented Oct 20, 2022

View reviewed changes

proposals/3912-relation-based-redaction.md Outdated Show resolved Hide resolved

anoadragon453 reviewed Oct 21, 2022

View reviewed changes

proposals/3912-relation-based-redaction.md Outdated Show resolved Hide resolved

proposals/3912-relation-based-redaction.md Show resolved Hide resolved

Incorporate review

5823324

turt2live reviewed Nov 22, 2022

View reviewed changes

proposals/3912-relation-based-redaction.md Show resolved Hide resolved

Florian14 mentioned this pull request Nov 29, 2022

Voice Broadcast - Handle event deletion when listening or recording element-hq/element-android#7629

Merged

15 tasks

weeman1337 mentioned this pull request Dec 8, 2022

Implement MSC3912: Relation-based redactions matrix-org/matrix-js-sdk#2954

Merged

3 tasks

richvdh reviewed Dec 19, 2022

View reviewed changes

proposals/3912-relation-based-redaction.md Show resolved Hide resolved

Florian14 mentioned this pull request Jan 11, 2023

Fix unexpected live voice broadcast in the room list element-hq/element-android#7898

Merged

15 tasks

giomfo mentioned this pull request Jan 18, 2023

Implement MSC3912 to delete server side all the data of the deleted voice broadcast element-hq/element-ios#7283

Closed

giomfo mentioned this pull request Jan 18, 2023

Implement MSC3912 to delete server side all the data of the deleted voice broadcast element-hq/element-android#7967

Closed

nimau mentioned this pull request Jan 20, 2023

Implement MSC3912: redaction with relations matrix-org/matrix-ios-sdk#1688

Merged

richvdh reviewed Apr 25, 2023

View reviewed changes

proposals/3912-relation-based-redaction.md Outdated Show resolved Hide resolved

proposals/3912-relation-based-redaction.md Outdated Show resolved Hide resolved

Incorporate review

7fe8d6f

- Update title - Correct the provided example, and clarify some use cases

giomfo changed the title ~~MSC3912: Relation-based redactions~~ MSC3912: Redaction of related events May 4, 2023

richvdh self-requested a review May 30, 2023 10:00

weeman1337 mentioned this pull request May 30, 2023

Update MSC3912 implementation to use with_rel_type instead of with_relations matrix-org/matrix-js-sdk#3420

Merged

3 tasks

richvdh requested changes May 31, 2023

View reviewed changes

richvdh reviewed May 31, 2023

View reviewed changes

proposals/3912-relation-based-redaction.md Outdated Show resolved Hide resolved

MatMaul mentioned this pull request Jun 1, 2023

Add a catch-all * to the supported relation types when redacting matrix-org/synapse#15705

Merged

4 tasks

anoadragon453 mentioned this pull request Jun 1, 2023

Clarify how to make use of unstable prefixes in your MSC #4024

Merged

giomfo and others added 2 commits June 12, 2023 15:30

Update proposals/3912-relation-based-redaction.md

938e3ef

Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>

Update the "Unstable feature in /versions" section

1b3176c

matrixbot mentioned this pull request Dec 21, 2023

Implement MSC3912: Relation-based redactions element-hq/synapse#14231

Open

2 tasks

Johennes mentioned this pull request Jan 17, 2025

GSC291: Löschkonzept v2 gematik/api-ti-messenger#291

Closed

Conversation

babolivier commented Oct 18, 2022 • edited by giomfo Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

weeman1337 commented Dec 7, 2022

Uh oh!

babolivier commented Dec 7, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

giomfo commented May 29, 2023

Uh oh!

richvdh May 31, 2023

Choose a reason for hiding this comment

Uh oh!

giomfo Jun 12, 2023

Choose a reason for hiding this comment

Uh oh!

richvdh May 31, 2023

Choose a reason for hiding this comment

Uh oh!

richvdh May 31, 2023

Choose a reason for hiding this comment

Uh oh!

richvdh May 31, 2023

Choose a reason for hiding this comment

Uh oh!

giomfo Jun 12, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

babolivier commented Oct 18, 2022 •

edited by giomfo

Loading