Skip to content

Remove 'room_id' field from m.typing, m.receipt and m.fully_read examples and schema #3679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
richvdh merged 5 commits into from
Mar 1, 2022
Merged

Remove 'room_id' field from m.typing, m.receipt and m.fully_read examples and schema #3679

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e0e6774
Remove 'room_id' field from EDU example
anoadragon453 Jan 26, 2022
e691b23
Remove 'room_id' from m.typing schema
anoadragon453 Jan 28, 2022
b27339b
Remove room_id from m.typing and m.receipt schema
anoadragon453 Feb 8, 2022
598fb33
Additionally remove room_id from m.fully_read room account data
anoadragon453 Feb 8, 2022
9449e07
Changelog
anoadragon453 Mar 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions data/event-schemas/examples/core/room_edu.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
{
"$ref": "event.json",
"room_id": "!jEsUZKDJdhlrceRyVU:example.org"
"$ref": "event.json"
}
1 change: 0 additions & 1 deletion data/event-schemas/examples/m.fully_read.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{
"$ref": "core/event.json",
"type": "m.fully_read",
"room_id": "!somewhere:example.org",
"content": {
"event_id": "$someplace:example.org"
}
Expand Down
6 changes: 1 addition & 5 deletions data/event-schemas/schema/m.fully_read.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,7 @@
"type": {
"type": "string",
"enum": ["m.fully_read"]
},
"room_id": {
"type": "string",
"description": "The room ID the read marker applies to."
}
},
"required": ["type", "room_id", "content"]
"required": ["type", "content"]
}
5 changes: 1 addition & 4 deletions data/event-schemas/schema/m.receipt.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,7 @@
"type": {
"type": "string",
"enum": ["m.receipt"]
},
"room_id": {
"type": "string"
}
},
"required": ["room_id", "type", "content"]
"required": ["type", "content"]
}
5 changes: 1 addition & 4 deletions data/event-schemas/schema/m.typing.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,7 @@
"type": {
"type": "string",
"enum": ["m.typing"]
},
"room_id": {
"type": "string"
}
},
"required": ["type", "room_id", "content"]
"required": ["type", "content"]
}