OpenAPI: add auth property in uploadCrossSigningKeys#3331
Merged
uhoreg merged 1 commit intomatrix-org:masterfrom Aug 12, 2021
Merged
OpenAPI: add auth property in uploadCrossSigningKeys#3331uhoreg merged 1 commit intomatrix-org:masterfrom
uhoreg merged 1 commit intomatrix-org:masterfrom
Conversation
uhoreg
approved these changes
Aug 12, 2021
Member
uhoreg
left a comment
uhoreg
left a comment
There was a problem hiding this comment.
Can you add a signoff and a changelog? Other than that, looks good.
Signed-off-by: Lukas Lihotzki <lukas@lihotzki.de>
richvdh
pushed a commit
that referenced
this pull request
Aug 23, 2021
OpenAPI: add auth property in uploadCrossSigningKeys
richvdh
pushed a commit
that referenced
this pull request
Aug 27, 2021
OpenAPI: add auth property in uploadCrossSigningKeys
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The description mentions this API endpoint uses the User-Interactive Authentication API and this is used in practice, but the auth property is missing.