Skip to content

MSC3030: Jump to date API endpoint#3030

Merged
turt2live merged 28 commits intoold_masterfrom
eric/msc-jump-to-date
Nov 6, 2022
Merged

MSC3030: Jump to date API endpoint#3030
turt2live merged 28 commits intoold_masterfrom
eric/msc-jump-to-date

Conversation

@MadLittleMods
Copy link
Copy Markdown
Contributor

@MadLittleMods MadLittleMods commented Feb 25, 2021

@MadLittleMods MadLittleMods changed the title MSC0000: Jump to date API endpoint MSC3030: Jump to date API endpoint Feb 25, 2021
@MadLittleMods MadLittleMods marked this pull request as draft February 25, 2021 01:59
@turt2live turt2live added client-server Client-Server API kind:feature MSC for not-core and not-maintenance stuff proposal A matrix spec change proposal labels Feb 25, 2021
@Half-Shot Half-Shot self-assigned this Mar 4, 2021
@turt2live turt2live added the needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. label Jun 8, 2021
MadLittleMods added a commit to matrix-org/complement that referenced this pull request Jul 28, 2021
@MadLittleMods MadLittleMods marked this pull request as ready for review October 4, 2021 21:50
@MadLittleMods MadLittleMods changed the base branch from old_master to main November 16, 2021 04:17
@MadLittleMods MadLittleMods changed the base branch from main to old_master November 16, 2021 04:21
MadLittleMods added a commit to matrix-org/synapse that referenced this pull request Dec 2, 2021
…he closest event to a given timestamp (#9445)

MSC3030: matrix-org/matrix-spec-proposals#3030

Client API endpoint. This will also go and fetch from the federation API endpoint if unable to find an event locally or we found an extremity with possibly a closer event we don't know about.
```
GET /_matrix/client/unstable/org.matrix.msc3030/rooms/<roomID>/timestamp_to_event?ts=<timestamp>&dir=<direction>
{
    "event_id": ...
    "origin_server_ts": ...
}
```

Federation API endpoint:
```
GET /_matrix/federation/unstable/org.matrix.msc3030/timestamp_to_event/<roomID>?ts=<timestamp>&dir=<direction>
{
    "event_id": ...
    "origin_server_ts": ...
}
```

Co-authored-by: Erik Johnston <[email protected]>
Copy link
Copy Markdown
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall the proposal looks great - just a few editorial comments :)

@turt2live
Copy link
Copy Markdown
Member

I appear to be the only one with the concern, so in the interest of not blocking this needlessly:

@mscbot resolve Server doesn't appear to be able to forwards-fill over federation

we should, however, figure out how to fix this at some point.

@mscbot
Copy link
Copy Markdown
Collaborator

mscbot commented Nov 1, 2022

🔔 This is now entering its final comment period, as per the review above. 🔔

@mscbot
Copy link
Copy Markdown
Collaborator

mscbot commented Nov 6, 2022

The final comment period, with a disposition to merge, as per the review above, is now complete.

@dhenneke
Copy link
Copy Markdown
Contributor

dhenneke commented Nov 7, 2022

image

@turt2live shouldn't this go into main?

@turt2live
Copy link
Copy Markdown
Member

Older MSCs go to old_master due to branch conflicts, and will be brought over to main over time (usually when I'm at a terminal that can cherry pick)

@MadLittleMods
Copy link
Copy Markdown
Contributor Author

Thanks all for the review! 😇

Next up is stabilizing the implementations in Synapse and Element where I made the experimental implementations.

@turt2live
Copy link
Copy Markdown
Member

Spec PR (WIP as of writing): matrix-org/matrix-spec#1366

@uhoreg
Copy link
Copy Markdown
Member

uhoreg commented Dec 21, 2022

Merged! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client-server Client-Server API kind:feature MSC for not-core and not-maintenance stuff merged A proposal whose PR has merged into the spec! proposal A matrix spec change proposal

Projects

Status: Merged/Done

Development

Successfully merging this pull request may close these issues.