MSC2746: Improved VoIP Signalling#2746
Merged
anoadragon453 merged 81 commits intoold_masterfrom Apr 28, 2023
Merged
Conversation
Member
Author
|
There's no implementation of this yet: seeking early feedback in advance of starting an impl. |
ara4n
reviewed
Aug 22, 2020
ara4n
reviewed
Aug 22, 2020
ara4n
reviewed
Aug 22, 2020
ara4n
reviewed
Aug 22, 2020
Replaces `answer_id` with `party_id` and introduces the `invitee` field on `m.call.invite`.
babolivier
reviewed
Sep 3, 2020
Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
richvdh
reviewed
Sep 11, 2020
Member
richvdh
left a comment
richvdh
left a comment
There was a problem hiding this comment.
all seems generally sane to me.
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
anoadragon453
approved these changes
Apr 23, 2023
Member
anoadragon453
left a comment
anoadragon453
left a comment
There was a problem hiding this comment.
I only have wording corrections. The rest of the logic looks sound!
proposals/2746-reliable-voip.md
Outdated
Comment on lines
+19
to
+23
| The version property is changed to `"1"` in all existing VoIP events | ||
| ([`m.call.answer`](https://spec.matrix.org/v1.5/client-server-api/#mcallanswer), | ||
| [`m.call.candidates`](https://spec.matrix.org/v1.5/client-server-api/#mcallcandidates), | ||
| [`m.call.hangup`](https://spec.matrix.org/v1.5/client-server-api/#mcallhangup) | ||
| [`m.call.invite`](https://spec.matrix.org/v1.5/client-server-api/#mcallinvite)). |
Member
There was a problem hiding this comment.
Could you call out more explicitly that you're changing the type of the version field across all of these event types from a number/integer to a string? (Or just link to the Unstable Prefix section of this MSC, having now read it.)
Collaborator
|
🔔 This is now entering its final comment period, as per the review above. 🔔 |
mscbot
added
final-comment-period
Collaborator
|
The final comment period, with a disposition to merge, as per the review above, is now complete. |
mscbot
added
finished-final-comment-period
and removed
disposition-merge
final-comment-period
anoadragon453
added
spec-pr-missing
anoadragon453
pushed a commit
that referenced
this pull request
Apr 28, 2023
Member
|
Spec PR: matrix-org/matrix-spec#1511 |
turt2live
added
spec-pr-in-review
Member
|
Merged 🎉 |
turt2live
added
merged
12 tasks
This was referenced May 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A proposal introducing a number of mechanisms to 1:1 VoIP calls, adding:
Implementation: https://github.com/matrix-org/matrix-js-sdk/tree/develop/src/webrtc
Rendered
FCP tickyboxes