initial spec for cross-signing#2536
Conversation
|
Not sure which lines and thus don't know where to do line-comments on the PR, but in |
| } | ||
| } | ||
|
|
||
| master_keys: |
There was a problem hiding this comment.
Is there a way to only query the cross-signing keys? Is it sufficient to query only one device key of a user to them in the reply, or do you need to query all device keys of a user (empty list)?
There was a problem hiding this comment.
No, there's no way to query just the cross-signing keys. Querying device is sufficient. The user's ID just needs to appear in the query.
Yes, that seems to just be the way our documentation generator works. On fact, the whole body is a parameter, but since it doesn't have any listed properties, the documentation generator thinks there's nothing there. |
|
As a comment that came out of matrix-org/synapse#7594, it's not super obvious that the USK is only used by its owner and isn't sent to other servers over federation (unlike the two other keys), maybe this could be detailed here? |
Words (and diagram!) have been added that hopefully clarify this. |
richvdh
left a comment
There was a problem hiding this comment.
generally looks great. a few bits and bobs.
| security: | ||
| - accessToken: [] | ||
| parameters: | ||
| - in: body |
There was a problem hiding this comment.
this isn't working in the rendered output, for some reason.
There was a problem hiding this comment.
It's because our generator wants the body to have a fixed set of properties, rather than being a mapping of IDs, so I don't think this can be fixed without making changes to the build system.
| schema: | ||
| type: object | ||
| properties: | ||
| failures: |
api/server-server/definitions/event-schemas/m.signing_key_update.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
Spec PR for #1756
Does not have any mentions of SSSS, since that is not written up yet.
Rendered version of changes at