feat(oauth): expose sessions expiration errors during QR login#5898
Merged
poljar merged 4 commits intomatrix-org:mainfrom Nov 26, 2025
Merged
feat(oauth): expose sessions expiration errors during QR login#5898poljar merged 4 commits intomatrix-org:mainfrom
poljar merged 4 commits intomatrix-org:mainfrom
Conversation
…zvous channel Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
…usServer Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
653d6b8 to
a144d20
Compare
…h a QR code Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
…ith a QR code Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
a144d20 to
13b2273
Compare
CodSpeed Performance ReportMerging #5898 will not alter performanceComparing Summary
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5898 +/- ##
==========================================
+ Coverage 88.65% 88.66% +0.01%
==========================================
Files 362 362
Lines 103146 103363 +217
Branches 103146 103363 +217
==========================================
+ Hits 91440 91645 +205
- Misses 7458 7471 +13
+ Partials 4248 4247 -1 ☔ View full report in Codecov by Sentry. |
poljar
approved these changes
Nov 26, 2025
Contributor
poljar
left a comment
There was a problem hiding this comment.
Makes sense, thanks for the extensive tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSC4108 designates 404 /
M_NOT_FOUNDto non-existing (and possibly expired) rendezvous sessions. This introduces dedicatedNotFounderrors so that consumers of the SDK can handle this case accordingly.