refactor(oidc): Align logout behavior with MSC4254#4674
Merged
poljar merged 3 commits intomatrix-org:mainfrom Feb 24, 2025
Merged
refactor(oidc): Align logout behavior with MSC4254#4674poljar merged 3 commits intomatrix-org:mainfrom
poljar merged 3 commits intomatrix-org:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4674 +/- ##
==========================================
+ Coverage 85.89% 85.93% +0.04%
==========================================
Files 291 290 -1
Lines 33868 33839 -29
==========================================
- Hits 29091 29080 -11
+ Misses 4777 4759 -18 ☔ View full report in Codecov by Sentry. |
zecakeh
force-pushed
the
rm-rp-initiated-logout
branch
from
76e28df to
7d47231
Compare
poljar
requested changes
Feb 24, 2025
Contributor
poljar
left a comment
poljar
left a comment
There was a problem hiding this comment.
Alright, sorry for the delay. I wanted to test this PR since we don't have integration tests with a real OIDC provider. Can confirm, it works with beta.matrix.org.
I left a small nit and could you please get rid of the merge conflict, then we can merge.
Token revocation was split out from MSC2964 to MSC4254, and RP-Initiated logout is now mentioned only as an alternative. Signed-off-by: Kévin Commaille <[email protected]>
The server is supposed to revoke any token associated with the token that we revoke. Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
zecakeh
force-pushed
the
rm-rp-initiated-logout
branch
from
7d47231 to
d0cf1ae
Compare
Collaborator
Author
|
I rebased on main to solve the conflicts |
poljar
approved these changes
Feb 24, 2025
stefanceriu
added a commit
to element-hq/element-x-ios
that referenced
this pull request
Feb 25, 2025
stefanceriu
added a commit
to element-hq/element-x-ios
that referenced
this pull request
Feb 25, 2025
stefanceriu
added a commit
to element-hq/element-x-ios
that referenced
this pull request
Feb 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Token revocation was split out from MSC2964 (commit matrix-org/matrix-spec-proposals@c859c0b, section called "Logout initiated from a Matrix client") to MSC4254.
According to MSC4254: