ffi(bindings): check if MSC 4028 is enabled on the homeserver#2840
ffi(bindings): check if MSC 4028 is enabled on the homeserver#2840
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2840 +/- ##
==========================================
- Coverage 82.33% 82.33% -0.01%
==========================================
Files 211 211
Lines 21620 21620
==========================================
- Hits 17801 17800 -1
- Misses 3819 3820 +1 ☔ View full report in Codecov by Sentry. |
better naming better doc
ab5500a to
ed2b595
Compare
Co-authored-by: Jonas Platte <[email protected]>
|
@Velin92 there is some ambiguity here. The right way to check the support of a feature server side is to used the |
|
Note: I just added msc4028 to the /_matrix/clients/versions endpoint at the spec level: matrix-org/matrix-spec-proposals@d3a1e87 |
Added a function that returns true if the current homeserver has the msc 4028 push rule and is enabled.
Since I don't see Ruma having a specific push rule id for it yet, I am using an hardcoded string for now, is that okay?