Device manager - rename session (PSG-528) by kerryarchibald · Pull Request #9282 · matrix-org/matrix-react-sdk

kerryarchibald · 2022-09-15T09:05:10Z

Screen.Recording.2022-09-15.at.13.52.40.mov

Checklist

Tests written for new code (and old code if feasible)
Linter and other CI checks pass
Sign-off given on the changes (see CONTRIBUTING.md)

Notes: Device manager - rename session

Here's what your changelog entry will look like:

✨ Features

Device manager - rename session (#9282). Contributed by @kerryarchibald.

weeman1337 · 2022-09-15T14:32:48Z

res/css/components/views/settings/devices/_DeviceDetailHeading.pcss

+}
+
+.mx_DeviceDetailHeading_renameForm {
+    display: grid;


We could use flex here. With 100 % width this behaves like a flex layout.
(Or I just don't know a feature of grid 😆 )

weeman1337 · 2022-09-15T14:37:29Z

src/components/views/settings/devices/DeviceDetailHeading.tsx

+        }
+    };
+
+    const headingId = `device-rename-${device.device_id}`;


We should ensure that IDs don't contain spaces.

weeman1337 · 2022-09-15T14:39:30Z

test/components/views/settings/devices/DeviceDetailHeading-test.tsx

+
+    it('renders device name', () => {
+        const { container } = render(getComponent());
+        expect({ container }).toMatchSnapshot();


To check if it renders the device name we could test for it.
Scalpel vs snapshot-shotgun 😆

weeman1337 · 2022-09-15T14:41:05Z

test/components/views/settings/tabs/user/SessionManagerTab-test.tsx

+            fireEvent.click(getByTestId('device-rename-submit-cta'));
+
+            await flushPromisesWithFakeTimers();
+            await flushPromisesWithFakeTimers();


Can you add a comment, why this is needed twice?

weeman1337 · 2022-09-15T14:42:16Z

@kerryarchibald I was too late 🏃

Maybe you can have a look at the comments anyway.

@dhenneke

* Element Call video rooms ([\#9267](matrix-org/matrix-react-sdk#9267)). * Device manager - rename session ([\#9282](matrix-org/matrix-react-sdk#9282)). * Allow widgets to read related events ([\#9210](matrix-org/matrix-react-sdk#9210)). Contributed by @dhenneke. * Device manager - logout of other session ([\#9280](matrix-org/matrix-react-sdk#9280)). * Device manager - logout current session ([\#9275](matrix-org/matrix-react-sdk#9275)). * Device manager - verify other devices ([\#9274](matrix-org/matrix-react-sdk#9274)). * Allow integration managers to remove users ([\#9211](matrix-org/matrix-react-sdk#9211)). * Device manager - add verify current session button ([\#9252](matrix-org/matrix-react-sdk#9252)). * Add NotifPanel dot back. ([\#9242](matrix-org/matrix-react-sdk#9242)). Fixes element-hq/element-web#17641. * Implement MSC3575: Sliding Sync ([\#8328](matrix-org/matrix-react-sdk#8328)). * Add the clipboard read permission for widgets ([\#9250](matrix-org/matrix-react-sdk#9250)). Contributed by @stefanmuhle. * Make autocomplete pop-up wider in thread view ([\#9289](matrix-org/matrix-react-sdk#9289)). * Fix soft crash around inviting invalid MXIDs in start DM on first message flow ([\#9281](matrix-org/matrix-react-sdk#9281)). Fixes matrix-org/element-web-rageshakes#15060 and matrix-org/element-web-rageshakes#15140. * Fix in-reply-to previews not disappearing when swapping rooms ([\#9278](matrix-org/matrix-react-sdk#9278)). * Fix invalid instanceof operand window.OffscreenCanvas ([\#9276](matrix-org/matrix-react-sdk#9276)). Fixes element-hq/element-web#23275. * Fix memory leak caused by unremoved listener ([\#9273](matrix-org/matrix-react-sdk#9273)). * Fix thumbnail generation when offscreen canvas fails ([\#9272](matrix-org/matrix-react-sdk#9272)). Fixes element-hq/element-web#23265. * Prevent sliding sync from showing a room under multiple sublists ([\#9266](matrix-org/matrix-react-sdk#9266)). * Fix tile crash around tooltipify links ([\#9270](matrix-org/matrix-react-sdk#9270)). Fixes element-hq/element-web#23253. * Device manager - filter out nulled metadatas in device tile properly ([\#9251](matrix-org/matrix-react-sdk#9251)). * Fix a sliding sync bug which could cause rooms to loop ([\#9268](matrix-org/matrix-react-sdk#9268)). * Remove the grey gradient on images in bubbles in the timeline ([\#9241](matrix-org/matrix-react-sdk#9241)). Fixes element-hq/element-web#21651. * Fix html export not including images ([\#9260](matrix-org/matrix-react-sdk#9260)). Fixes element-hq/element-web#22059. * Fix possible soft crash from a race condition in space hierarchies ([\#9254](matrix-org/matrix-react-sdk#9254)). Fixes matrix-org/element-web-rageshakes#15225. * Disable all types of autocorrect, -complete, -capitalize, etc on Spotlight's search field ([\#9259](matrix-org/matrix-react-sdk#9259)). * Handle M_INVALID_USERNAME on /register/available ([\#9237](matrix-org/matrix-react-sdk#9237)). Fixes element-hq/element-web#23161. * Fix issue with quiet zone around QR code ([\#9243](matrix-org/matrix-react-sdk#9243)). Fixes element-hq/element-web#23199.

@dhenneke

* Element Call video rooms ([\element-hq#9267](matrix-org/matrix-react-sdk#9267)). * Device manager - rename session ([\element-hq#9282](matrix-org/matrix-react-sdk#9282)). * Allow widgets to read related events ([\element-hq#9210](matrix-org/matrix-react-sdk#9210)). Contributed by @dhenneke. * Device manager - logout of other session ([\element-hq#9280](matrix-org/matrix-react-sdk#9280)). * Device manager - logout current session ([\element-hq#9275](matrix-org/matrix-react-sdk#9275)). * Device manager - verify other devices ([\element-hq#9274](matrix-org/matrix-react-sdk#9274)). * Allow integration managers to remove users ([\element-hq#9211](matrix-org/matrix-react-sdk#9211)). * Device manager - add verify current session button ([\element-hq#9252](matrix-org/matrix-react-sdk#9252)). * Add NotifPanel dot back. ([\#9242](matrix-org/matrix-react-sdk#9242)). Fixes element-hq#17641. * Implement MSC3575: Sliding Sync ([\element-hq#8328](matrix-org/matrix-react-sdk#8328)). * Add the clipboard read permission for widgets ([\element-hq#9250](matrix-org/matrix-react-sdk#9250)). Contributed by @stefanmuhle. * Make autocomplete pop-up wider in thread view ([\element-hq#9289](matrix-org/matrix-react-sdk#9289)). * Fix soft crash around inviting invalid MXIDs in start DM on first message flow ([\element-hq#9281](matrix-org/matrix-react-sdk#9281)). Fixes matrix-org/element-web-rageshakes#15060 and matrix-org/element-web-rageshakes#15140. * Fix in-reply-to previews not disappearing when swapping rooms ([\element-hq#9278](matrix-org/matrix-react-sdk#9278)). * Fix invalid instanceof operand window.OffscreenCanvas ([\element-hq#9276](matrix-org/matrix-react-sdk#9276)). Fixes element-hq#23275. * Fix memory leak caused by unremoved listener ([\element-hq#9273](matrix-org/matrix-react-sdk#9273)). * Fix thumbnail generation when offscreen canvas fails ([\element-hq#9272](matrix-org/matrix-react-sdk#9272)). Fixes element-hq#23265. * Prevent sliding sync from showing a room under multiple sublists ([\element-hq#9266](matrix-org/matrix-react-sdk#9266)). * Fix tile crash around tooltipify links ([\element-hq#9270](matrix-org/matrix-react-sdk#9270)). Fixes element-hq#23253. * Device manager - filter out nulled metadatas in device tile properly ([\element-hq#9251](matrix-org/matrix-react-sdk#9251)). * Fix a sliding sync bug which could cause rooms to loop ([\element-hq#9268](matrix-org/matrix-react-sdk#9268)). * Remove the grey gradient on images in bubbles in the timeline ([\element-hq#9241](matrix-org/matrix-react-sdk#9241)). Fixes element-hq#21651. * Fix html export not including images ([\element-hq#9260](matrix-org/matrix-react-sdk#9260)). Fixes element-hq#22059. * Fix possible soft crash from a race condition in space hierarchies ([\element-hq#9254](matrix-org/matrix-react-sdk#9254)). Fixes matrix-org/element-web-rageshakes#15225. * Disable all types of autocorrect, -complete, -capitalize, etc on Spotlight's search field ([\element-hq#9259](matrix-org/matrix-react-sdk#9259)). * Handle M_INVALID_USERNAME on /register/available ([\element-hq#9237](matrix-org/matrix-react-sdk#9237)). Fixes element-hq#23161. * Fix issue with quiet zone around QR code ([\element-hq#9243](matrix-org/matrix-react-sdk#9243)). Fixes element-hq#23199.

@dhenneke

* Element Call video rooms ([\matrix-org#9267](matrix-org#9267)). * Device manager - rename session ([\matrix-org#9282](matrix-org#9282)). * Allow widgets to read related events ([\matrix-org#9210](matrix-org#9210)). Contributed by @dhenneke. * Device manager - logout of other session ([\matrix-org#9280](matrix-org#9280)). * Device manager - logout current session ([\matrix-org#9275](matrix-org#9275)). * Device manager - verify other devices ([\matrix-org#9274](matrix-org#9274)). * Allow integration managers to remove users ([\matrix-org#9211](matrix-org#9211)). * Device manager - add verify current session button ([\matrix-org#9252](matrix-org#9252)). * Add NotifPanel dot back. ([\matrix-org#9242](matrix-org#9242)). Fixes element-hq/element-web#17641. * Implement MSC3575: Sliding Sync ([\matrix-org#8328](matrix-org#8328)). * Add the clipboard read permission for widgets ([\matrix-org#9250](matrix-org#9250)). Contributed by @stefanmuhle. * Make autocomplete pop-up wider in thread view ([\matrix-org#9289](matrix-org#9289)). * Fix soft crash around inviting invalid MXIDs in start DM on first message flow ([\matrix-org#9281](matrix-org#9281)). Fixes matrix-org/element-web-rageshakes#15060 and matrix-org/element-web-rageshakes#15140. * Fix in-reply-to previews not disappearing when swapping rooms ([\matrix-org#9278](matrix-org#9278)). * Fix invalid instanceof operand window.OffscreenCanvas ([\matrix-org#9276](matrix-org#9276)). Fixes element-hq/element-web#23275. * Fix memory leak caused by unremoved listener ([\matrix-org#9273](matrix-org#9273)). * Fix thumbnail generation when offscreen canvas fails ([\matrix-org#9272](matrix-org#9272)). Fixes element-hq/element-web#23265. * Prevent sliding sync from showing a room under multiple sublists ([\matrix-org#9266](matrix-org#9266)). * Fix tile crash around tooltipify links ([\matrix-org#9270](matrix-org#9270)). Fixes element-hq/element-web#23253. * Device manager - filter out nulled metadatas in device tile properly ([\matrix-org#9251](matrix-org#9251)). * Fix a sliding sync bug which could cause rooms to loop ([\matrix-org#9268](matrix-org#9268)). * Remove the grey gradient on images in bubbles in the timeline ([\matrix-org#9241](matrix-org#9241)). Fixes element-hq/element-web#21651. * Fix html export not including images ([\matrix-org#9260](matrix-org#9260)). Fixes element-hq/element-web#22059. * Fix possible soft crash from a race condition in space hierarchies ([\matrix-org#9254](matrix-org#9254)). Fixes matrix-org/element-web-rageshakes#15225. * Disable all types of autocorrect, -complete, -capitalize, etc on Spotlight's search field ([\matrix-org#9259](matrix-org#9259)). * Handle M_INVALID_USERNAME on /register/available ([\matrix-org#9237](matrix-org#9237)). Fixes element-hq/element-web#23161. * Fix issue with quiet zone around QR code ([\matrix-org#9243](matrix-org#9243)). Fixes element-hq/element-web#23199.

https://build.opensuse.org/request/show/1007179 by user favogt + RBrownFactory - Version 1.11.8 ## 🐛 Bug Fixes * Bump IDB crypto store version ([\#2705](matrix-org/matrix-js-sdk#2705)). - Version 1.11.7 ## 🔒 Security * Fix for [CVE-2022-39249](https://cve.mitre.org/cgi-bin/cvekey.cgi?keyword=CVE%2D2022%2D39249) * Fix for [CVE-2022-39250](https://cve.mitre.org/cgi-bin/cvekey.cgi?keyword=CVE%2D2022%2D39250) * Fix for [CVE-2022-39251](https://cve.mitre.org/cgi-bin/cvekey.cgi?keyword=CVE%2D2022%2D39251) * Fix for [CVE-2022-39236](https://cve.mitre.org/cgi-bin/cvekey.cgi?keyword=CVE%2D2022%2D39236) - Version 1.11.6 ## ✨ Features * Element Call video rooms ([\#9267](matrix-org/matrix-react-sdk#9267)). * Device manager - rename session ([\#9282](matrix-org/matrix-react-sdk#9282)). * Allow widgets t

Kerry Archibald added 7 commits September 15, 2022 10:53

split heading into component

056eed2

switch between editing and view

1b2cd71

style file

3955346

basic tests

2912346

style device rename component

2bfef5d

add loading state

79d8b2d

kind of handle missing current device in drilled props

83c1951

kerryarchibald added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Sep 15, 2022

kerryarchibald mentioned this pull request Sep 15, 2022

Generic typography component - Caption #9283

Merged

3 tasks

github-actions bot deployed to Netlify September 15, 2022 09:09 View deployment

kerryarchibald force-pushed the psg-528/rename-session branch from 243f3e6 to 83c1951 Compare September 15, 2022 09:54

github-actions bot deployed to Netlify September 15, 2022 09:58 View deployment

Kerry Archibald added 4 commits September 15, 2022 13:31

use local loading state, add basic error message

7933cd6

integration-ish test rename

6d74cb4

tidy

5953e44

fussy import ordering

1f6de25

github-actions bot deployed to Netlify September 15, 2022 12:35 View deployment

kerryarchibald marked this pull request as ready for review September 15, 2022 12:56

kerryarchibald requested a review from a team as a code owner September 15, 2022 12:56

kerryarchibald requested review from duxovni, t3chguy and weeman1337 September 15, 2022 12:56

Merge branch 'develop' into psg-528/rename-session

2a8fe57

github-actions bot deployed to Netlify September 15, 2022 13:02 View deployment

strict errors

f491afc

github-actions bot deployed to Netlify September 15, 2022 14:13 View deployment

duxovni approved these changes Sep 15, 2022

View reviewed changes

kerryarchibald merged commit 4fec436 into develop Sep 15, 2022

kerryarchibald deleted the psg-528/rename-session branch September 15, 2022 14:34

weeman1337 reviewed Sep 15, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Device manager - rename session (PSG-528)#9282

Device manager - rename session (PSG-528)#9282
kerryarchibald merged 13 commits intodevelopfrom
psg-528/rename-session

kerryarchibald commented Sep 15, 2022 •

edited by github-actions bot

Loading

Uh oh!

weeman1337 Sep 15, 2022

Uh oh!

weeman1337 Sep 15, 2022

Uh oh!

weeman1337 Sep 15, 2022

Uh oh!

weeman1337 Sep 15, 2022

Uh oh!

weeman1337 commented Sep 15, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

kerryarchibald commented Sep 15, 2022 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

✨ Features

Uh oh!

weeman1337 Sep 15, 2022

Choose a reason for hiding this comment

Uh oh!

weeman1337 Sep 15, 2022

Choose a reason for hiding this comment

Uh oh!

weeman1337 Sep 15, 2022

Choose a reason for hiding this comment

Uh oh!

weeman1337 Sep 15, 2022

Choose a reason for hiding this comment

Uh oh!

weeman1337 commented Sep 15, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kerryarchibald commented Sep 15, 2022 •

edited by github-actions bot

Loading