Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Device manager - device security recommendation card (PSG-637)#9158

Merged
kerryarchibald merged 27 commits intodevelopfrom
psg-637/device-man-card
Aug 11, 2022
Merged

Device manager - device security recommendation card (PSG-637)#9158
kerryarchibald merged 27 commits intodevelopfrom
psg-637/device-man-card

Conversation

@kerryarchibald
Copy link
Copy Markdown
Contributor

@kerryarchibald kerryarchibald commented Aug 9, 2022 •
edited by github-actions bot
Loading

Screenshot 2022-08-09 at 15 33 34

Screenshot 2022-08-10 at 17 32 18

Screenshot 2022-08-10 at 17 25 24

  • Deprecates e2e warning and unverified svgs that use hardcoded colors, to avoid large refactor
  • adds new warning and unverified svgs that use currentColor
  • add light variant of warning and verified colours
  • adds new device security recommendation card

NB: these are not used yet, to avoid blocking this PR on #9151

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Notes: Device manager - device security recommendation card

This change is marked as an internal change (Task), so will not be included in the changelog.

@kerryarchibald kerryarchibald added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Aug 9, 2022
@kerryarchibald kerryarchibald requested a review from a team as a code owner August 9, 2022 15:01
@kerryarchibald kerryarchibald force-pushed the psg-637/device-man-card branch 2 times, most recently from fa0f00c to d1aee34 Compare August 10, 2022 08:55
SimonBrandner
SimonBrandner reviewed Aug 10, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@SimonBrandner SimonBrandner left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking sane though I am confused about the icon changes + it would be good to use compound colors

@kerryarchibald kerryarchibald enabled auto-merge (squash) August 11, 2022 09:11
@kerryarchibald kerryarchibald merged commit 7b52145 into develop Aug 11, 2022
@kerryarchibald kerryarchibald deleted the psg-637/device-man-card branch August 11, 2022 10:39
@luixxiul luixxiul mentioned this pull request Mar 19, 2023
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@t3chguy t3chguy Awaiting requested review from t3chguy t3chguy is a code owner automatically assigned from matrix-org/element-web-reviewers

@duxovni duxovni Awaiting requested review from duxovni duxovni is a code owner automatically assigned from matrix-org/element-web-reviewers

2 more reviewers

@weeman1337 weeman1337 weeman1337 approved these changes

@SimonBrandner SimonBrandner SimonBrandner approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

T-Task Refactoring, enabling or disabling functionality, other engineering tasks

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kerryarchibald @weeman1337 @SimonBrandner