This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Device manager - selectable device tile wrapper (PSG-637)#9153
Merged
kerryarchibald merged 3 commits intodevelopfrom Aug 9, 2022
Merged
Device manager - selectable device tile wrapper (PSG-637)#9153kerryarchibald merged 3 commits intodevelopfrom
kerryarchibald merged 3 commits intodevelopfrom
Conversation
kerryarchibald
added
the
T-Task
Contributor
|
Is it by intent that the icons and the checkboxes are off by some pixels?
Eventually, if updating this section, we can align it? |
weeman1337
approved these changes
Aug 9, 2022
Contributor
weeman1337
left a comment
weeman1337
left a comment
There was a problem hiding this comment.
Otherwise LGTM; checked deployment; works 👍
Contributor
Author
|
@weeman1337 good spot, lined it up a bit better. (That section is going away soon) |
Contributor
|
Now they are right-aligned 😆 I though more of centre-align them:
Anyway if the section will be removed/replaced soon let's keep it like it is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces existing device tile checkbox styling with new composable
SelectableDeviceTile, to be used in new designChecklist
Notes: Device manager - selectable device tile wrapper
This change is marked as an internal change (Task), so will not be included in the changelog.