Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Start DM on first message#8612

Merged
weeman1337 merged 102 commits intomatrix-org:developfrom
weeman1337:feat-dm-on-first
Aug 4, 2022
Merged

Start DM on first message#8612
weeman1337 merged 102 commits intomatrix-org:developfrom
weeman1337:feat-dm-on-first

Conversation

@weeman1337
Copy link
Copy Markdown
Contributor

@weeman1337 weeman1337 commented May 16, 2022

ToDo

  • implement error handling
  • all tasks from the comments
  • test
    • verification from room member list
    • click message in room member list

After merge:

  • Display something meaningful if opening a local room URL for an unknown room → create new issue

Test checklist

  • Start DM from new spotlight search
  • DM with single MXID
  • DM with multiple MXID
  • DM with single 3PID (e-email)
  • DM with mixed IDs
  • Start DM with
    • Text message
    • Sticker
    • Location
    • Live location
    • Poll
    • Voice message
    • Attachment
      • Upload via composer button
        • Single file
        • Multiple files
      • Drag & drop
        • Single file
        • Multiple files
      • Paste from clipboard
        • Single file

Closes element-hq/element-web#14736

PSD-249


Here's what your changelog entry will look like:

✨ Features

@weeman1337 weeman1337 added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label May 16, 2022
@weeman1337 weeman1337 force-pushed the feat-dm-on-first branch 2 times, most recently from afce921 to e5c488a Compare May 16, 2022 17:13
Signed-off-by: Michael Weimann <michaelw@matrix.org>
Signed-off-by: Michael Weimann <michaelw@matrix.org>
Signed-off-by: Michael Weimann <michaelw@matrix.org>
Signed-off-by: Michael Weimann <michaelw@matrix.org>
Signed-off-by: Michael Weimann <michaelw@matrix.org>
Signed-off-by: Michael Weimann <michaelw@matrix.org>
Signed-off-by: Michael Weimann <michaelw@matrix.org>
@giomfo
Copy link
Copy Markdown
Member

giomfo commented May 20, 2022

@weeman1337 FYI I tried it in the Netlify deployment. This is a very good start
I observed one point that we can fix easily, the local room should not be displayed if an actual DM is already existing for the selected contact. In your current implementation, I switch on the actual DM after I fill my message in the local/fake room

@SimonBrandner SimonBrandner added X-Blocked The PR cannot move forward in any capacity until an action is made and removed X-Blocked The PR cannot move forward in any capacity until an action is made labels Jul 25, 2022
@SimonBrandner
Copy link
Copy Markdown
Contributor

(wrong PR - sorry!)

@weeman1337
Copy link
Copy Markdown
Contributor Author

For the reviewers: This PR is now ready for review.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Only create DM room when first message is sent

7 participants