This repository was archived by the owner on Sep 11, 2024. It is now read-only.
replace all require(.svg) with esm import#7948
Merged
kerryarchibald merged 1 commit intodevelopfrom Mar 2, 2022
Merged
Conversation
Signed-off-by: Kerry Archibald <kerrya@element.io>
kerryarchibald
pushed a commit
that referenced
this pull request
Mar 3, 2022
This reverts commit 61cd463.
kerryarchibald
pushed a commit
that referenced
this pull request
Mar 3, 2022
* Revert "replace all require(svgs) with esm import (#7948)" This reverts commit 61cd463. * add .default to svg icon inline requires Signed-off-by: Kerry Archibald <kerrya@element.io> * add shameful eslint ignore Signed-off-by: Kerry Archibald <kerrya@element.io> * format eslintrc Signed-off-by: Kerry Archibald <kerrya@element.io> * add missed MFileBody change Signed-off-by: Kerry Archibald <kerrya@element.io> * one more broken svg Signed-off-by: Kerry Archibald <kerrya@element.io> * and ignore it Signed-off-by: Kerry Archibald <kerrya@element.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: element-hq/element-web#21271
Update all require imports of svgs to use ESM imports.
Ideally we wouldn't use these img tag icons any longer, but replacing them with react icon components would involve style changes and would be error prone in a batch as large as this.
This PR currently has no changelog labels, so will not be included in changelogs.
A reviewer can add one of:
T-Deprecation,T-Enhancement,T-Defect,T-Taskto indicate what type of change this is, or addType: [enhancement/defect/task]to the description and I'll add them for you.Preview: https://pr7948--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.