This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Tidy up timelineRenderingType to be passed over context#7872
Merged
Tidy up timelineRenderingType to be passed over context#7872
Conversation
t3chguy
added
the
T-Task
kerryarchibald
approved these changes
Feb 22, 2022
| dis.dispatch({ | ||
| ...payload, | ||
| dis.dispatch<ComposerInsertPayload>({ | ||
| ...(payload as ComposerInsertPayload), |
Contributor
There was a problem hiding this comment.
If you use a union type on the signature payload: ActionPayload | ComposerInsertPayload | etc then the switch will do the type assertion and the cast of payload here won't be needed.
Member
Author
There was a problem hiding this comment.
payload: ActionPayload | ComposerInsertPayload doesn't work, to my knowledge we'd need to eliminate ActionPayload and only use the union type of the actual cases, most of the actual Payload types are missing definitions at this time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is marked as an internal change (Task), so will not be included in the changelog.
Preview: https://pr7872--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.