Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Add CSS variable to make the UI gaps consistent and fix the resize handle position#7234

Merged
toger5 merged 13 commits intodevelopfrom
toger5/gap_refactoring_main_split
Dec 6, 2021
Merged

Add CSS variable to make the UI gaps consistent and fix the resize handle position#7234
toger5 merged 13 commits intodevelopfrom
toger5/gap_refactoring_main_split

Conversation

@toger5
Copy link
Copy Markdown
Contributor

@toger5 toger5 commented Nov 30, 2021

Fixes: element-hq/element-web#19904
Fixes: element-hq/element-web#19938
This changes the gap width and makes it consistent all over element. It can be adjusted for the whole UI using the css variable $container-gap-width.
It would be best, if design could propose or approve the value for the gaps (Right now I chose 8px).
image
image
image

Additionally this changes which part part of the resizable is responsible for the gap. Now the main split has a marigin of $container-gap-width/2 and the right/left panel as well so that the resizeHandle is automatically in the center of the gap and not closer to one of the elements. This also reduces the trickery needed with the resizeHandle::before element (the resize indicator):
image
image
Before:
image


Here's what your changelog entry will look like:

✨ Features

Preview: https://61adf6973059ca16aacbefff--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.

Loading
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Maximised widgets don't have any bottom margin Optimize spacing between the AppsDrawer and the right/left panel

2 participants