This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Add CSS variable to make the UI gaps consistent and fix the resize handle position#7234
Merged
Add CSS variable to make the UI gaps consistent and fix the resize handle position#7234
Conversation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: element-hq/element-web#19904



Fixes: element-hq/element-web#19938
This changes the gap width and makes it consistent all over element. It can be adjusted for the whole UI using the css variable
$container-gap-width.It would be best, if design could propose or approve the value for the gaps (Right now I chose 8px).
Additionally this changes which part part of the resizable is responsible for the gap. Now the main split has a marigin of



$container-gap-width/2and the right/left panel as well so that the resizeHandle is automatically in the center of the gap and not closer to one of the elements. This also reduces the trickery needed with the resizeHandle::before element (the resize indicator):Before:
Here's what your changelog entry will look like:
✨ Features
Preview: https://61adf6973059ca16aacbefff--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.