This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Ensure my votes from a different device show up#7233
Merged
andybalaam merged 7 commits intomatrix-org:developfrom Dec 2, 2021
Merged
Ensure my votes from a different device show up#7233andybalaam merged 7 commits intomatrix-org:developfrom
andybalaam merged 7 commits intomatrix-org:developfrom
Conversation
andybalaam
added
the
T-Task
turt2live
reviewed
Dec 1, 2021
Member
turt2live
left a comment
turt2live
left a comment
There was a problem hiding this comment.
otherwise lgtm - mostly just future proofing with the undocumented UnstableValue class (sorry, this is my fault).
Co-authored-by: Travis Ralston <[email protected]>
Co-authored-by: Travis Ralston <[email protected]>
Co-authored-by: Travis Ralston <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After this change:
(Before this change):
This change is marked as an internal change (Task), so will not be included in the changelog.
Preview: https://61a8fd8a704d8b3bd508732e--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.