This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Highlight my vote even if it was made on another device#7202
Merged
andybalaam merged 3 commits intomatrix-org:developfrom Nov 26, 2021
Merged
Highlight my vote even if it was made on another device#7202andybalaam merged 3 commits intomatrix-org:developfrom
andybalaam merged 3 commits intomatrix-org:developfrom
Conversation
andybalaam
added
the
T-Task
t3chguy
approved these changes
Nov 25, 2021
| const userVotes = this.collectUserVotes(); | ||
| const votes = countVotes(userVotes, this.props.mxEvent.getContent()); | ||
| const totalVotes = this.totalVotes(votes); | ||
| const userId = MatrixClientPeg.get().getUserId(); |
Member
There was a problem hiding this comment.
can we use a MatrixClientContext here instead of MatrixClientPeg?
Member
Author
There was a problem hiding this comment.
Something like 17b726c ? I've never used this before so please check I did it right :-)
Member
There was a problem hiding this comment.
Yup! This way will make any future transitions to a multi-account world much easier, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is marked as an internal change (Task), so will not be included in the changelog.
Preview: https://61a0a702f2428631a8a14fd3--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.