Display started polls in timeline (without votes) (behind labs setting)#7088
Conversation
andybalaam
added
the
T-Enhancement
andybalaam
added
T-Task
germain-gg
left a comment
germain-gg
left a comment
There was a problem hiding this comment.
Looks good to me, even though you obviously chose the wrong answer in that poll... 🇫🇷
There was a problem hiding this comment.
- The hover state should show background colour for option frames
Current:
Desired
- The poll creator name and avatar should be the same size and layout, colour as a normal text message.
Current:
Desired:
- Also it seems to take a long time for the poll to be rendered on the timeline when I press Create poll from the modal. Unsure what can be done on this one.
I tried it just now and it was instant, so I think the delay you saw was probably not related to the work we are doing here. |
gaelledel
left a comment
gaelledel
left a comment
There was a problem hiding this comment.
Amazing, thanks for the changes :)
Could you double check that the frame options is set to Quinary for both themes? Otherwise all good, cheers.
|
@gaelledel do you mean the circular border of the radio buttons? Should that be quinary? In #7087 I made it quaternary - was that incorrect? |
|
No I meant the rectangular border of options on the timeline |
Cool, yes these are quinary. Thank you! |
3 participants
It doesn't work yet, but this shows polls in the timeline, and allows you to click options to see how they look.
Posting this PR in the hope of getting early feedback on the visual design and code structure.
This change is marked as an internal change (Task), so will not be included in the changelog.
Preview: https://618bac011943fa006f02f0e2--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.